- Notifications
You must be signed in to change notification settings - Fork669
fix: #593 by adding global flag to remove cache#602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Changes fromall commits
File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -3,10 +3,12 @@ | ||
| import * as cp from "child_process"; | ||
| import * as fse from "fs-extra"; | ||
| import * as os from "os"; | ||
| import * as path from "path"; | ||
| import * as requireFromString from "require-from-string"; | ||
| import { ExtensionContext } from "vscode"; | ||
| import { ConfigurationChangeEvent, Disposable, MessageItem, window, workspace, WorkspaceConfiguration } from "vscode"; | ||
| import { Endpoint, IProblem,leetcodeHasInited,supportedPlugins } from "./shared"; | ||
| import { executeCommand, executeCommandWithProgress } from "./utils/cpUtils"; | ||
| import { DialogOptions, openUrl } from "./utils/uiUtils"; | ||
| import * as wsl from "./utils/wslUtils"; | ||
| @@ -34,7 +36,11 @@ class LeetCodeExecutor implements Disposable { | ||
| return `"${path.join(this.leetCodeRootPath, "bin", "leetcode")}"`; | ||
| } | ||
| public async meetRequirements(context: ExtensionContext): Promise<boolean> { | ||
| const hasInited: boolean | undefined = context.globalState.get(leetcodeHasInited); | ||
| if (!hasInited) { | ||
| await this.removeOldCache(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Reuse the command we have? https://github.com/LeetCode-OpenSource/vscode-leetcode/blob/master/src/extension.ts#L51 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Seems a little different.The command way use leetcode-cli way not delete the whole dir, let me check if it works fine too. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. @jdneo Member There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Maybe we need to change the implementation of the command There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Yes, current one only clean the user info(include session), but we change the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. I see. So let's keep the implementation. Maybe later we can provide two option in this command. Something like | ||
| } | ||
| if (this.nodeExecutable !== "node") { | ||
| if (!await fse.pathExists(this.nodeExecutable)) { | ||
| throw new Error(`The Node.js executable does not exist on path ${this.nodeExecutable}`); | ||
| @@ -60,10 +66,13 @@ class LeetCodeExecutor implements Disposable { | ||
| for (const plugin of supportedPlugins) { | ||
| try { // Check plugin | ||
| await this.executeCommandEx(this.nodeExecutable, [await this.getLeetCodeBinaryPath(), "plugin", "-e", plugin]); | ||
| } catch (error) { // Remove old cache that may cause the error download plugin and activate | ||
| await this.removeOldCache(); | ||
| await this.executeCommandEx(this.nodeExecutable, [await this.getLeetCodeBinaryPath(), "plugin", "-i", plugin]); | ||
| } | ||
| } | ||
| // Set the global state HasInited true to skip delete old cache after init | ||
| context.globalState.update(leetcodeHasInited, true); | ||
| return true; | ||
| } | ||
| @@ -76,7 +85,7 @@ class LeetCodeExecutor implements Disposable { | ||
| } | ||
| public async signOut(): Promise<string> { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. It seems that its an old typo so I changed it too, am I right? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. yes | ||
| return await this.executeCommandEx(this.nodeExecutable, [await this.getLeetCodeBinaryPath(), "user", "-L"]); | ||
| } | ||
| public async listProblems(showLocked: boolean): Promise<string> { | ||
| @@ -194,6 +203,14 @@ class LeetCodeExecutor implements Disposable { | ||
| } | ||
| return await executeCommandWithProgress(message, command, args, options); | ||
| } | ||
| private async removeOldCache(): Promise<void> { | ||
| const oldPath: string = path.join(os.homedir(), ".lc"); | ||
| if (await fse.pathExists(oldPath)) { | ||
| await fse.remove(oldPath); | ||
| } | ||
| } | ||
| } | ||
| export const leetCodeExecutor: LeetCodeExecutor = new LeetCodeExecutor(); | ||
