- Notifications
You must be signed in to change notification settings - Fork670
fix: #593 by adding global flag to remove cache#602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| public async meetRequirements(context: ExtensionContext): Promise<boolean> { | ||
| const isUserFresh: boolean | undefined = context.globalState.get(globalStateLeetcodeIsUserFresh); | ||
| if (isUserFresh !== false) { | ||
| await this.removeOldCache(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Reuse the command we have?
https://github.com/LeetCode-OpenSource/vscode-leetcode/blob/master/src/extension.ts#L51
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Seems a little different.The command way use leetcode-cli way not delete the whole dir, let me check if it works fine too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@jdneo
delete cache only delete the user session but not the plugin.js cache, still have that issue. So I think we can not use it..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Maybe we need to change the implementation of the commanddelete cache. Considering that the current implementation does not clean entirely?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yes, current one only clean the user info(include session), but we change thedelete cache also have one problem beacuse user may have two account one leetcode one leetcode-cn, if we change that. both will clean, but user may only want to clean the current cache.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I see. So let's keep the implementation. Maybe later we can provide two option in this command. Something likeSession andAll. Anyway it's not a high priority
src/leetCodeExecutor.ts Outdated
| public async meetRequirements(): Promise<boolean> { | ||
| public async meetRequirements(context: ExtensionContext): Promise<boolean> { | ||
| const isUserFresh: boolean | undefined = context.globalState.get(globalStateLeetcodeIsUserFresh); | ||
| if (isUserFresh !== false) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
if (!isUserFresh)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
if (!isUserFresh)
@jdneo
Seems not the same logic if use if (!isUserFresh)
src/leetCodeExecutor.ts Outdated
| await this.executeCommandEx(this.nodeExecutable, [await this.getLeetCodeBinaryPath(), "plugin", "-i", plugin]); | ||
| } | ||
| } | ||
| context.globalState.update(globalStateLeetcodeIsUserFresh, false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
In the end of activate() I set it to false, in the first it should be undefined so I use(isUserFresh !== false) logic to check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Then instead of calling itisUserFresh, it would be better to call itHasInited IMO. And set it totrue at the end ofactivate()
The aim of that is to avoid the two falsy valueundefined andfalse has two different meanings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Got it.
| @@ -84,7 +85,7 @@ class LeetCodeExecutor implements Disposable { | |||
| } | |||
| public async signOut(): Promise<string> { | |||
| return await await this.executeCommandEx(this.nodeExecutable, [await this.getLeetCodeBinaryPath(), "user", "-L"]); | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It seems that its an old typo so I changed it too, am I right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
yes
src/shared.ts Outdated
| @@ -114,3 +114,5 @@ export enum DescriptionConfiguration { | |||
| Both = "Both", | |||
| None = "None", | |||
| } | |||
| export const globalStateLeetcodeHasInited: string = "leetcode.isUserFresh"; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Please also change the value. No need to have the prefixglobalState I think. Since when you calling the API, that API name already tells it's a global state
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Got it~!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks@yihong0618 !
No description provided.