- Notifications
You must be signed in to change notification settings - Fork669
Centralize the logic about wsl#55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
jdneo commentedAug 7, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Hi@purocean, As we have discussed before. We can have some further improvement about the WSL support. During my own experience, the main problems of current implementation are:
So this is the reason I create a new class: Very appreciated if you can help review this PR if you have time. Since this feature is originally contributed by you. 😄 |
@jdneo OK, I'll take a look. |
purocean commentedAug 8, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@jdneo
It occurs an error in my machine. https://github.com/jdneo/vscode-leetcode/blob/8c52f42f37bcc48b0f79210545169e629ec456d3/src/utils/nodeUtils.ts#L10 Looks like have no specific treatment for WSL. |
@purocean Nice finding! I'll fix it. |
@purocean Updated. Please have a try when you have time. |
@jdneo
|
@purocean Emm, I'm sorry. Anything wrong with "Submitting to LeetCode..."? |
@jdneo |
Haha, got it. We can revisit the wording issue if we get user feedbacks in the future. |
Uh oh!
There was an error while loading.Please reload this page.
fix#48
fix#54