Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: replace the LeetCode.svg and LeetCode.png#419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jdneo merged 2 commits intoLeetCode-OpenSource:masterfrompoppinlp:new_logo
Sep 16, 2019

Conversation

poppinlp
Copy link
Contributor

@poppinlppoppinlp commentedSep 16, 2019•
edited by jdneo
Loading

  • Replace theLeetCode.svg andLeetCode.png
  • Add JIEJIAN21 in contributors
  • Seems my markdown plugin reformated the table in README.md to make the separator in the same column.

Address#401

@jdneo
Copy link
Member

Thanks@poppinlp, could you fix the CI error?

ERROR Images in README.md must come from an HTTPS source: ./resources/LeetCode.png

@poppinlp
Copy link
ContributorAuthor

poppinlp commentedSep 16, 2019•
edited
Loading

This error is occured by the url ofLeetCode.png inREADME.md andREADME_zh-CN.md.
I've modified the url to local relative path instead of the file from master branch of github repository.

Actually, I think it's good to use relative path here since we should use the resources from current branch. But seems vsce dose not support it right now according tothis issue.

I've changed it back to pass the travis CI.

jdneo reacted with hooray emoji

@jdneojdneo merged commit237e56f intoLeetCode-OpenSource:masterSep 16, 2019
@jdneo
Copy link
Member

Hey@poppinlp

Just one more question. Now the extension icon and the activity bar icon are both using the new picture. Are we mean to discard the activity bar icon that your friend designed just before?

@poppinlppoppinlp deleted the new_logo branchSeptember 17, 2019 03:10
@poppinlp
Copy link
ContributorAuthor

I think I made a mistake. I should only replace the image in README. The previous activity icon is much more fits the sidebar. I'll bring it back now.
image

@jdneojdneo added this to the0.15.5 milestoneSep 28, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jdneojdneojdneo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.15.5
Development

Successfully merging this pull request may close these issues.

2 participants
@poppinlp@jdneo
[8]ページ先頭
©2009-2025 Movatter.jp