Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

implement leetcode.filePath#380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jdneo merged 8 commits intoLeetCode-OpenSource:masterfrommagic-akari:relativeFilePath
Sep 10, 2019
Merged

implement leetcode.filePath#380

jdneo merged 8 commits intoLeetCode-OpenSource:masterfrommagic-akari:relativeFilePath
Sep 10, 2019

Conversation

magic-akari
Copy link
Contributor

No description provided.

@jdneojdneo mentioned this pull requestAug 22, 2019
@jdneo
Copy link
Member

jdneo commentedSep 4, 2019
edited
Loading

Hi@magic-akari,

Apologize for the late reply about this PR. I was busying with other stuff the days before. Today I just got a chance to take a look at it.

Very nicely implemented I think! Just some small questions. Would you mind to take a look?

Thanks

@jdneojdneo added this to the0.15.4 milestoneSep 4, 2019
@magic-akari
Copy link
ContributorAuthor

There are a lot of duplicate codes inleetcode.filePath config.
I have tried to usejson schema's ref to reuse them, but it doesn't work in vscode.
Do you have any idea?

@jdneo
Copy link
Member

@magic-akari Yes, from engineering aspect, have the configuration clean and neat is a worth considering topic. While from the feature aspect, the changes here is good to go. Let me take a look at how to simplify the configuration inpackage.json this weekend.

If we cannot address it for now, we can create an issue to track that and ship this feature out to benefit our users first.

Thanks.

@jdneojdneo merged commit2d4266f intoLeetCode-OpenSource:masterSep 10, 2019
@jdneo
Copy link
Member

Thank you@magic-akari! Nice work!

@jdneojdneo changed the titleimplement leetcode.relativeFilePathimplement leetcode.filePathSep 13, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jdneojdneojdneo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.15.4
Development

Successfully merging this pull request may close these issues.

2 participants
@magic-akari@jdneo

[8]ページ先頭

©2009-2025 Movatter.jp