- Notifications
You must be signed in to change notification settings - Fork668
implement leetcode.filePath#380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
jdneo commentedSep 4, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Hi@magic-akari, Apologize for the late reply about this PR. I was busying with other stuff the days before. Today I just got a chance to take a look at it. Very nicely implemented I think! Just some small questions. Would you mind to take a look? Thanks |
There are a lot of duplicate codes in |
@magic-akari Yes, from engineering aspect, have the configuration clean and neat is a worth considering topic. While from the feature aspect, the changes here is good to go. Let me take a look at how to simplify the configuration in If we cannot address it for now, we can create an issue to track that and ship this feature out to benefit our users first. Thanks. |
Thank you@magic-akari! Nice work! |
No description provided.