Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Support showing description from text document#294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
Vigilans wants to merge9 commits intomasterfromvigilans/codelens

Conversation

Vigilans
Copy link
Contributor

@VigilansVigilans commentedApr 26, 2019•
edited
Loading

Solves#286

Relies onleetcode-tools/leetcode-cli#13

Demonstration:
demo2

@VigilansVigilans requested a review fromjdneoApril 26, 2019 16:19
@jdneo
Copy link
Member

@Vigilans First of all, thank you for the enthusiasm you give.

One thing I have to mentions is that, please do not try to solve multiple issues in one PR. This very hard for tracking the issues.

Could you please revert this PR to make it only solve#287 first. And please let me know what I can do to help you achieve that.

Thanks.

@Vigilans
Copy link
ContributorAuthor

Vigilans commentedApr 27, 2019•
edited
Loading

#287 has already been solved in#289 4 days ago and is waiting for theleetcode-cli dependency update.

This three issues all point to the same thing (comment in#287 is duplicate of#286), splitting this PR will result in a PR of 90% content and a PR with 10% content.

@Vigilans
Copy link
ContributorAuthor

Could you please revert this PR to make it only solve#287 first. And please let me know what I can do to help you achieve that.

This PR doesn't solve#287

@jdneo
Copy link
Member

I see. I've added comments in#289.

But still, I would like to request you to split the PR even it's 10% + 90%. Thank you for your understanding.

@VigilansVigilans changed the titleSupport showing description and solution from text documentSupport showing description from text documentApr 27, 2019
@VigilansVigilans deleted the vigilans/codelens branchMay 9, 2019 15:21
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jdneojdneoAwaiting requested review from jdneo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@Vigilans@jdneo
[8]ページ先頭
©2009-2025 Movatter.jp