Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add side mode to webview#271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jdneo merged 11 commits intomasterfromvigilans/webview-sidemode
Apr 22, 2019
Merged

Add side mode to webview#271

jdneo merged 11 commits intomasterfromvigilans/webview-sidemode
Apr 22, 2019

Conversation

@Vigilans
Copy link
Contributor

Walkthrough:
WalkThrough

ShowProblem command also benefits from it:
ShowProblem

Solution weview always follows the state of preview:
Preview Solution

What if the title doesn't change (this is on a wide-screen computer):
WhatIf

@VigilansVigilans requested a review fromjdneoApril 16, 2019 12:14
@jdneo
Copy link
Member

Thanks, I'll take a look tomorrow.

@Vigilans
Copy link
ContributorAuthor

enableSideMode walkthrough:
enableSideMode

Copy link
Member

@jdneojdneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM.

Would you mind also update the document(about the setting:leetcode.enableSideMode) in this PR as well?

@jdneojdneo added this to the0.13.4 milestoneApr 22, 2019
@Vigilans
Copy link
ContributorAuthor

Document added.

@jdneojdneo merged commit52a84d3 intomasterApr 22, 2019
@VigilansVigilans deleted the vigilans/webview-sidemode branchApril 22, 2019 08:26
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@jdneojdneojdneo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.14.0

Development

Successfully merging this pull request may close these issues.

3 participants

@Vigilans@jdneo
[8]ページ先頭
©2009-2025 Movatter.jp