Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Apply mdEngine to preview webview#257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jdneo merged 12 commits intoLeetCode-OpenSource:masterfromVigilans:webview-md-preview
Apr 14, 2019
Merged

Apply mdEngine to preview webview#257

jdneo merged 12 commits intoLeetCode-OpenSource:masterfromVigilans:webview-md-preview
Apr 14, 2019

Conversation

Vigilans
Copy link
Contributor

@VigilansVigilans commentedApr 3, 2019•
edited
Loading

Prerequisities

before merging this PR.

Demonstration

demo3

image

image

image

image

image

@VigilansVigilans requested a review fromjdneoApril 3, 2019 11:06
await commands.executeCommand("leetcode.showProblem", this.node);
this.dispose();
return;
await commands.executeCommand("workbench.action.focusSecondEditorGroup");
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This line relates to (maybe) a bug in vscode, and I have reported in a issue:
microsoft/vscode#71608, which makes me have to create column 2 first before moving (by callingreveal(ViewColumn.Two)) the webview panel to it.

I've successfully build the vscode repository locally in the aftertoon, and I'd like to have a try to debug the vscode myself.

private parseDescription(descString: string, problem: IProblem): IDescription {
const [
/* title */, ,
url, ,
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Each comma without variable before it means ignore this line (normally empty line, or something not needed)

@VigilansVigilans added this to the0.13.3 milestoneApr 3, 2019
@jdneojdneo modified the milestones:0.13.3,0.13.4Apr 4, 2019
@poppinlp
Copy link
Contributor

Looks cool! 👍

@jdneojdneo merged commitecac298 intoLeetCode-OpenSource:masterApr 14, 2019
@VigilansVigilans mentioned this pull requestApr 14, 2019
@VigilansVigilans deleted the webview-md-preview branchApril 14, 2019 05:29
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jdneojdneojdneo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.14.0
Development

Successfully merging this pull request may close these issues.

3 participants
@Vigilans@poppinlp@jdneo
[8]ページ先頭
©2009-2025 Movatter.jp