Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Several behavior fix#235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jdneo merged 4 commits intoLeetCode-OpenSource:masterfromVigilans:cs/behaviorfix
Mar 26, 2019
Merged

Several behavior fix#235

jdneo merged 4 commits intoLeetCode-OpenSource:masterfromVigilans:cs/behaviorfix
Mar 26, 2019

Conversation

Vigilans
Copy link
Contributor

Introduction

Old behavior:

  • When quickpicking language, if click other areas to cancel the selection, anundefined default language query will pop out:
    image
  • Sometimes, the leetcode-cli may print useful data, but exit with error code. In this case, an exception will be thrown, and useful data will not be passed.
  • When submitting a solution, leetcode-cli may printRuntime error and exit with error code. With aforementioned behavior, an exception will be thrown, and result WebView cannot be shown.
    image

New behavior:

  • Perform extra check before default language query.
  • When exiting with error code, collect the result data into the error object.
  • When showing result provider, if there is any result data in the caught error object, extract it out to build the WebView. Otherwise, re-throw the error object.

@VigilansVigilans requested a review fromjdneoMarch 25, 2019 15:55
Copy link
Member

@jdneojdneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

These are very good improvements for the extension.

@Vigilans Would you mind to create the issues for those bugs separately and link them to the PR here? Then I can cover these issues into the changelog.

@@ -68,7 +68,7 @@ async function fetchProblemLanguage(): Promise<string | undefined> {
const language: string | undefined = defaultLanguage || await vscode.window.showQuickPick(languages, { placeHolder: "Select the language you want to use" });
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We can also addignoreFocusOut: true into theshowQuickPick()'s option to avoid user close the drop list by mistake

@Vigilans
Copy link
ContributorAuthor

Tracked in the issues#236 and#237 .

@jdneojdneo merged commit3028be4 intoLeetCode-OpenSource:masterMar 26, 2019
@VigilansVigilans deleted the cs/behaviorfix branchMarch 26, 2019 09:50
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jdneojdneojdneo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@Vigilans@jdneo

[8]ページ先頭

©2009-2025 Movatter.jp