- Notifications
You must be signed in to change notification settings - Fork670
Several behavior fix#235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
These are very good improvements for the extension.
@Vigilans Would you mind to create the issues for those bugs separately and link them to the PR here? Then I can cover these issues into the changelog.
src/commands/show.ts Outdated
@@ -68,7 +68,7 @@ async function fetchProblemLanguage(): Promise<string | undefined> { | |||
const language: string | undefined = defaultLanguage || await vscode.window.showQuickPick(languages, { placeHolder: "Select the language you want to use" }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We can also addignoreFocusOut: true
into theshowQuickPick()
's option to avoid user close the drop list by mistake
Introduction
Old behavior:
undefined
default language query will pop out:Runtime error
and exit with error code. With aforementioned behavior, an exception will be thrown, and result WebView cannot be shown.New behavior: