Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Can hide the status bar#230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jdneo merged 3 commits intomasterfromcs/statusbar
Mar 22, 2019
Merged

Can hide the status bar#230

jdneo merged 3 commits intomasterfromcs/statusbar
Mar 22, 2019

Conversation

jdneo
Copy link
Member

Resolve#156

leetcode

@jdneojdneo added this to the0.13.2 milestoneMar 22, 2019
Vigilans
Vigilans previously approved these changesMar 22, 2019
Copy link
Contributor

@VigilansVigilans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Tested without problem in my Windows and Linux machine (but with some latency to show and hide after swiching the checkbox, maybe oneday we should deal with the performance problem?).

@jdneo
Copy link
MemberAuthor

@Vigilans Maybe instead of disposing the status bar item, I should hide it to improve the performance. I'll update the PR later

Copy link
Contributor

@VigilansVigilans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Tested agian, lgtm~

@jdneojdneo merged commitd12faba intomasterMar 22, 2019
@jdneojdneo deleted the cs/statusbar branchMarch 22, 2019 13:44
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@VigilansVigilansVigilans approved these changes

@poppinlppoppinlpAwaiting requested review from poppinlp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.13.2
Development

Successfully merging this pull request may close these issues.

2 participants
@jdneo@Vigilans

[8]ページ先頭

©2009-2025 Movatter.jp