Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[bugfix] Clicking 'Code Now' will open multiple files#216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jdneo merged 1 commit intomasterfromcs/bugfi
Mar 17, 2019

Conversation

jdneo
Copy link
Member

@jdneojdneo commentedMar 17, 2019•
edited
Loading

Fix#217

Bug repro step:

  1. Click 2-3 problem node to preview the description one by one
  2. ClickCode Now
  3. It will generate all the files for the problems that have been previewed before

Root cause:
The listeners are registered every time executingpreview (). They should be registered only once whenthis.panel has not been created.

@jdneojdneo added this to the0.13.1 milestoneMar 17, 2019
@jdneojdneo requested a review fromVigilansMarch 17, 2019 12:37
@Vigilans
Copy link
Contributor

I tested the bug on my side:
Click problem [3], [70], [169], and the behavior appears as expected. Besides, after testing the behavior multiple times, one of the problem may fail to be shown forJSON parse error on input. After this PR, this problem may disappear.

Other flaws of the preview command:

  • the extension will still fetch problem description after clicking the active problem node
  • did not make use of local cache

Copy link
Contributor

@VigilansVigilans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The preview'scode now works properly on my side now.

@jdneojdneo merged commit0fb736c intomasterMar 17, 2019
@jdneojdneo deleted the cs/bugfi branchMarch 17, 2019 13:07
@jdneo
Copy link
MemberAuthor

Merged for now. We can improve both thepreview and theresult webview in0.13.2 using the markdown solution, which I think can improve the experience significantly. Meanwhile, more bugs and some refactoring work can be addressed in0.13.2.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@VigilansVigilansVigilans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.13.1
Development

Successfully merging this pull request may close these issues.

2 participants
@jdneo@Vigilans
[8]ページ先頭
©2009-2025 Movatter.jp