Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Prepare for 0.13.0#204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jdneo merged 3 commits intomasterfromcs/0.13.0
Mar 15, 2019
Merged

Prepare for 0.13.0#204

jdneo merged 3 commits intomasterfromcs/0.13.0
Mar 15, 2019

Conversation

jdneo
Copy link
Member

@jdneojdneo commentedMar 13, 2019
edited
Loading

No description provided.

@jdneojdneo added this to the0.13.0 milestoneMar 13, 2019
@jdneojdneo marked this pull request as ready for reviewMarch 13, 2019 12:28
@jdneojdneo requested a review fromVigilansMarch 13, 2019 12:28
Copy link
Contributor

@VigilansVigilans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The solution rendering logic is not applied to preview and result yet. Is the version set to 0.13.x when done?

README.md Outdated
@@ -70,14 +70,23 @@
<img src="https://raw.githubusercontent.com/jdneo/vscode-leetcode/master/docs/imgs/pick_problem.png" alt="Pick a Problem" />
</p>

- Right click the problem in the `LeetCode Explorer` and select `Show Problem`will generate a new file with the problem description for you.
- Right click the problem in the `LeetCode Explorer` and select `Preview Problem` to see the problem description. Or select `Show Problem`to directly open the file with the problem description.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Left click the problem node would also trigger preview window, isn't it necessary to notify this?

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Good catch, I'll add this.

@jdneo
Copy link
MemberAuthor

yes, we can improve the rendering logic of preview and result in the later version, it's not a big problem.

@jdneojdneo merged commit0300764 intomasterMar 15, 2019
@jdneojdneo deleted the cs/0.13.0 branchMarch 15, 2019 08:50
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@VigilansVigilansVigilans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.13.0
Development

Successfully merging this pull request may close these issues.

2 participants
@jdneo@Vigilans

[8]ページ先頭

©2009-2025 Movatter.jp