Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

vscode versions to v1.31.0, add collapes all.#197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jdneo merged 2 commits intoLeetCode-OpenSource:masterfromZainChen:master
Mar 11, 2019
Merged

vscode versions to v1.31.0, add collapes all.#197

jdneo merged 2 commits intoLeetCode-OpenSource:masterfromZainChen:master
Mar 11, 2019

Conversation

ZainChen
Copy link
Contributor

@ZainChen
Copy link
ContributorAuthor

collapes all

@jdneo
Copy link
Member

@ZainChen Thank you for your contribution.

The featurecollapes all looks good to me, just on concern about it.

Could you make sure that1.31.0 is the lowest version to support this API? Cuz by upgrading the engine version, all the users who are using VS Code lower than1.31.0 could not use the extension anymore.

@ZainChen
Copy link
ContributorAuthor

The minimum version that supports this API is 1.30.1. Although the official 1.29.1 version pointed out the modifications, the interface appeared in version 1.30.1.
https://code.visualstudio.com/updates/v1_29
https://code.visualstudio.com/updates/v1_30

vscode version to 1.30.1
@ZainChen
Copy link
ContributorAuthor

The contribution version is changed to 1.30.1, you can prompt everyone to use the new version of vscode, everyone will like this feature.^_^

Copy link
Member

@jdneojdneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Cool, thank you for your contribution.

@jdneojdneo merged commitb85611b intoLeetCode-OpenSource:masterMar 11, 2019
@ZainChen
Copy link
ContributorAuthor

Thank you too, very happy to contribute to such a good expansion.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jdneojdneojdneo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@ZainChen@jdneo

[8]ページ先頭

©2009-2025 Movatter.jp