Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Top voted solution webview#193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jdneo merged 15 commits intoLeetCode-OpenSource:masterfromVigilans:solution-view
Mar 13, 2019
Merged

Top voted solution webview#193

jdneo merged 15 commits intoLeetCode-OpenSource:masterfromVigilans:solution-view
Mar 13, 2019

Conversation

Vigilans
Copy link
Contributor

Introduction

Solves#96
This PR is independent with#188.

Details

  • indented code block uses solution language to highlight.
  • uses built-in markdown extension to provide style files.

Demonstration

image

image

References

@jdneojdneo self-requested a reviewMarch 11, 2019 01:47
@jdneojdneo added this to the0.13.0 milestoneMar 11, 2019
@jdneo
Copy link
Member

@Vigilans Sorry for the conflict made by merging another PR, would you mind to resolve it?

@Vigilans
Copy link
ContributorAuthor

@jdneo Conflict has been resolved.

@jdneo
Copy link
Member

Cool, I'll take a look tonight

Copy link
Member

@jdneojdneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Very cool feature! Just some comments for small changes.

Copy link
Member

@jdneojdneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yes, still cannot get style work on my Mac...

@jdneo
Copy link
Member

@Vigilans Thank you for keep working on this PR, it's very near to get merged.

Vigilansand others added2 commitsMarch 13, 2019 16:59
* Revert plugin modification* Move markdown style error prompt from dialog to channel
Copy link
Member

@jdneojdneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Very nice work. This feature will significantly increase the user experience. And we can adopt the same render logic into the result provider and preview provider.

@jdneojdneo merged commit9b33df0 intoLeetCode-OpenSource:masterMar 13, 2019
@VigilansVigilans deleted the solution-view branchMarch 20, 2019 07:18
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jdneojdneojdneo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.13.0
Development

Successfully merging this pull request may close these issues.

2 participants
@Vigilans@jdneo
[8]ページ先頭
©2009-2025 Movatter.jp