Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add Click the tree explorer should open the topic (#132)#186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jdneo merged 8 commits intoLeetCode-OpenSource:masterfromxuzaixian:master
Mar 12, 2019

Conversation

xuzaixian
Copy link
Contributor

@xuzaixianxuzaixian commentedMar 5, 2019
edited by jdneo
Loading

Resolve#131

@jdneo
Copy link
Member

@xuzaixian Thank you for contribution.

From my understanding, after applying this change, when the user clicks on the tree node, we will generate new / open existing problem file, right?

@xuzaixian
Copy link
ContributorAuthor

yes ~

@jdneo
Copy link
Member

Emm, I'm ok to open the existing problem file.

While for the non-existing file, it will be better if we can first show the problem description to the user, and generate the file if the user has some further confirmation action. What do you think?

@xuzaixian
Copy link
ContributorAuthor

Hum....maybe we can preview the problem within a webview , and generate the file after confirmation action ?

@jdneo
Copy link
Member

@xuzaixian Exactly what I'm thinking about. And this action can be bound with a new command calledPreview Problem.

Would you like to have a try to implement this feature first?

@xuzaixian
Copy link
ContributorAuthor

ok, i will work on it.

@jdneo
Copy link
Member

@xuzaixian I'm thinking that if we should create a new command or just reuseShow Problem

@xuzaixian
Copy link
ContributorAuthor

I prefer to create a new commandPreview Problem .

use 'Show Problem' when they want to code right now
use 'Preview Problem' when they want to read description.
we can provide more choices to user 🤣

@jdneo
Copy link
Member

@xuzaixian So what should we do when user left-click on the node?

@xuzaixian
Copy link
ContributorAuthor

@jdneo How about just preview the problem description when user left-click?
We can provide an extra button calledCode Now or something else .. in preview window,
The user can click button to code right away.
Also provide a new menu option in right-click menu calledCode Now.

This sounds convenient.

@jdneo
Copy link
Member

@xuzaixian Yes, sounds good

@jdneo
Copy link
Member

Hi@xuzaixian,

I noticed that a lot of diffs is caused by reformating thepackage.json. Would you mind to revert those formatting changes? This could make it easier to review.

Thanks!

@jdneojdneo self-requested a reviewMarch 6, 2019 10:48
@xuzaixian
Copy link
ContributorAuthor

sorry for that 😢

Remove unused functionUse rem instead of pxUse the VS Code embed CSS vars in Preivew WebviewUse spaces instead of tabs in package.jsonUse previewProvider to manage preivew logic
@jdneo
Copy link
Member

jdneo commentedMar 8, 2019
edited
Loading

@xuzaixian You can install an extension called: TS Lint, to help you resolve those lint errors.

https://marketplace.visualstudio.com/items?itemName=ms-vscode.vscode-typescript-tslint-plugin

@xuzaixian
Copy link
ContributorAuthor

@jdneo
There is no error in my environment when i runvsce package
But The Travis CI build failed.
Can you take a look ?

@jdneo
Copy link
Member

@xuzaixian It's because the file system on Linux is case sensitive.

your file name isleetcodePreviewProvider.ts, but when you import it, you are usingleetCode.

Move the logic in webviewUtils.ts to leetCodePreviewProviderFix missing semicolonRename leetcodePreviewProvider to leetCodePreviewProvider
Copy link
Member

@jdneojdneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. Thank you@xuzaixian for the great work!

@jdneojdneo merged commitf77737d intoLeetCode-OpenSource:masterMar 12, 2019
@VigilansVigilans mentioned this pull requestMar 13, 2019
5 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jdneojdneojdneo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@xuzaixian@jdneo

[8]ページ先頭

©2009-2025 Movatter.jp