- Notifications
You must be signed in to change notification settings - Fork669
Add Click the tree explorer should open the topic (#132)#186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
@xuzaixian Thank you for contribution. From my understanding, after applying this change, when the user clicks on the tree node, we will generate new / open existing problem file, right? |
yes ~ |
Emm, I'm ok to open the existing problem file. While for the non-existing file, it will be better if we can first show the problem description to the user, and generate the file if the user has some further confirmation action. What do you think? |
Hum....maybe we can preview the problem within a webview , and generate the file after confirmation action ? |
@xuzaixian Exactly what I'm thinking about. And this action can be bound with a new command called Would you like to have a try to implement this feature first? |
ok, i will work on it. |
@xuzaixian I'm thinking that if we should create a new command or just reuse |
I prefer to create a new command use 'Show Problem' when they want to code right now |
@xuzaixian So what should we do when user left-click on the node? |
@jdneo How about just preview the problem description when user left-click? This sounds convenient. |
@xuzaixian Yes, sounds good |
Hi@xuzaixian, I noticed that a lot of diffs is caused by reformating the Thanks! |
sorry for that 😢 |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Remove unused functionUse rem instead of pxUse the VS Code embed CSS vars in Preivew WebviewUse spaces instead of tabs in package.jsonUse previewProvider to manage preivew logic
jdneo commentedMar 8, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@xuzaixian You can install an extension called: TS Lint, to help you resolve those lint errors. https://marketplace.visualstudio.com/items?itemName=ms-vscode.vscode-typescript-tslint-plugin |
@jdneo |
@xuzaixian It's because the file system on Linux is case sensitive. your file name is |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Move the logic in webviewUtils.ts to leetCodePreviewProviderFix missing semicolonRename leetcodePreviewProvider to leetCodePreviewProvider
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM. Thank you@xuzaixian for the great work!
Uh oh!
There was an error while loading.Please reload this page.
Resolve#131