Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Use internal build cli#179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jdneo merged 2 commits intomasterfromcs/cli
Mar 3, 2019
Merged

Use internal build cli#179

jdneo merged 2 commits intomasterfromcs/cli
Mar 3, 2019

Conversation

jdneo
Copy link
Member

Try toresolve#74,#83,#103,#105

@poppinlp Please help review when you have time. Thanks!

@jdneojdneo added this to the0.12.0 milestoneMar 3, 2019
@jdneojdneo requested a review frompoppinlpMarch 3, 2019 07:56
@jdneojdneo merged commitbc61447 intomasterMar 3, 2019
@jdneojdneo deleted the cs/cli branchMarch 3, 2019 11:09
@jdneo
Copy link
MemberAuthor

jdneo commentedMar 3, 2019•
edited
Loading

Let me explain more about this PR.

In this PR, I change the dependency fromleetcode-cli tovsc-leetcode-cli, which is a forked privacy build of theleetcode-cli. This is due to that the latest version ofleetcode-cli has some broken features and inactive for a long time. So I have to replace it with my forked version.

So far I have no plan to write a new cli tool to replace it. I'm very willing to merge back to the originleetcode-cli when it becomes active again.

BrambleXu reacted with thumbs up emoji

@twchn
Copy link

Using a forked version ofleetcode-cli is a better choice I think, we can keep in sync with the upstream(leetcode-cli), and then fix known issues ASAP or customize the extra features we need.

jdneo reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@poppinlppoppinlpAwaiting requested review from poppinlp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.

Power operator displays in a wrong way
2 participants
@jdneo@twchn
[8]ページ先頭
©2009-2025 Movatter.jp