- Notifications
You must be signed in to change notification settings - Fork689
Add tooltips for sub-category folder#143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
jdneo commentedFeb 20, 2019
@pujiaxun Sounds great. Would you mind to attach a screenshot in the PR? |
pujiaxun commentedFeb 20, 2019
Uh oh!
There was an error while loading.Please reload this page.
jdneo commentedFeb 20, 2019
@pujiaxun Just one small comment. |
pujiaxun commentedFeb 20, 2019
import*asosfrom"os";//...return[`AC:${numAC}`,`Not AC:${numNotAC}`,`Unknown:${numUnknown}`,`Total:${problems.length}`,].join(os.EOL); Like this?@jdneo |
jdneo commentedFeb 20, 2019
@pujiaxun Yes, looks much better. |
pujiaxun commentedFeb 20, 2019
@jdneo Any other suggestions? For instance, I think the name "Not AC" sounds weird... |
jdneo commentedFeb 20, 2019
@pujiaxun hmm, good question. Regarding the wording. My suggestion is Either |
pujiaxun commentedFeb 20, 2019
@jdneo I prefer to keep |
jdneo commentedFeb 20, 2019
Same to me. So let's keep |
jdneo left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Just one more comment
Uh oh!
There was an error while loading.Please reload this page.
jdneo left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@pujiaxun LGTM. Thank you for your contribution. Nice work.

Background: I wonder how many problems I have solved. Then I found the tooltip field is available for now. That's it~