Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add tooltips for sub-category folder#143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jdneo merged 4 commits intoLeetCode-OpenSource:masterfrompujiaxun:master
Feb 20, 2019

Conversation

pujiaxun
Copy link
Contributor

Background: I wonder how many problems I have solved. Then I found the tooltip field is available for now. That's it~

@jdneo
Copy link
Member

@pujiaxun Sounds great. Would you mind to attach a screenshot in the PR?

@pujiaxun
Copy link
ContributorAuthor

@pujiaxun Sounds great. Would you mind to attach a screenshot in the PR?

image

It looks like this.@jdneo

@jdneo
Copy link
Member

@pujiaxun Just one small comment.

@pujiaxun
Copy link
ContributorAuthor

import*asosfrom"os";//...return[`AC:${numAC}`,`Not AC:${numNotAC}`,`Unknown:${numUnknown}`,`Total:${problems.length}`,].join(os.EOL);

Like this?@jdneo

@jdneo
Copy link
Member

@pujiaxun Yes, looks much better.

@pujiaxun
Copy link
ContributorAuthor

@jdneo Any other suggestions? For instance, I think the name "Not AC" sounds weird...

@jdneo
Copy link
Member

@pujiaxun hmm, good question.

Regarding the wording. My suggestion isNot AC ->Failed

EitherUnknown orTotal, one of them can be removed I think? What do you think?

@pujiaxun
Copy link
ContributorAuthor

@jdneo I prefer to keepTotal if I have to give up one of them. After all, the tagUnknown is somewhat confusing.

@jdneo
Copy link
Member

Same to me. So let's keepAC,Failed andTotal.

Copy link
Member

@jdneojdneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Just one more comment

Copy link
Member

@jdneojdneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@pujiaxun LGTM. Thank you for your contribution. Nice work.

@jdneojdneo merged commit72acef9 intoLeetCode-OpenSource:masterFeb 20, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jdneojdneojdneo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@pujiaxun@jdneo

[8]ページ先頭

©2009-2025 Movatter.jp