Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

add outputPath Config#123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jdneo merged 15 commits intoLeetCode-OpenSource:masterfromringcrl:master
Feb 16, 2019
Merged

Conversation

ringcrl
Copy link
Contributor

@ringcrlringcrl commentedFeb 13, 2019
edited
Loading

add outputPath config for leetcode#119

Change Request,Need Help...Find a way to get a Problem difficulty...

@jdneo
Copy link
Member

@ringcrl

I think there is still some misunderstanding here. The aim of add the settingleetcode.outputPath is to make it possible for the users to categorize the files as their wish. So instead of make it as a enum setting, we should make it as a plain string.

Let me explain more about it:

The setting ofleetcode.outputPath has no default value, which means it is empty by default. And, by default, when the user clickshow problem, the file goes to the base path of the workspace folder.

If the user set some values to it, for example: 'happy' then the file goes to the folder calledhappy

Meanwhile, besides let the user customize the output folder, we will also provide somespecial values, which are, as you know,${tag},${language},${difficulty}. This means the user needs to explicitly brace the value with${}, then the extension will get to know that: Oh, this is not a general path. I need to traslate it to another value...

Do you get my point?

@ringcrl
Copy link
ContributorAuthor

Thank you very much, I have made changes.

@ringcrl
Copy link
ContributorAuthor

Thank you very much for these helpful suggestions.

@@ -16,16 +17,17 @@ export async function showProblem(node?: LeetCodeNode): Promise<void> {
if (!node) {
return;
}
await showProblemInternal(node.id);
await showProblemInternal(node);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Though type casting fromLeetCodeNode toIProblem is fine. Let's add getter inLeetCodeNode to get the data, which is typed asIProblem.

It looks like I need to do some refactors here later after this PR, The definition ofLeetCodeNode andIProblem is overlapped.

@ringcrl
Copy link
ContributorAuthor

Add tag selector

@jdneojdneo merged commit1cdca10 intoLeetCode-OpenSource:masterFeb 16, 2019
@jdneo
Copy link
Member

@ringcrl Looks much better now.

I just did some changes and merged the PR.

Thank you for your contribution.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jdneojdneojdneo requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@ringcrl@jdneo

[8]ページ先頭

©2009-2025 Movatter.jp