- Notifications
You must be signed in to change notification settings - Fork689
add outputPath Config#123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
jdneo commentedFeb 14, 2019
I think there is still some misunderstanding here. The aim of add the setting Let me explain more about it: The setting of If the user set some values to it, for example: 'happy' then the file goes to the folder called Meanwhile, besides let the user customize the output folder, we will also provide somespecial values, which are, as you know, Do you get my point? |
Uh oh!
There was an error while loading.Please reload this page.
ringcrl commentedFeb 14, 2019
Thank you very much, I have made changes. |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
ringcrl commentedFeb 15, 2019
Thank you very much for these helpful suggestions. |
Uh oh!
There was an error while loading.Please reload this page.
| return; | ||
| } | ||
| awaitshowProblemInternal(node.id); | ||
| awaitshowProblemInternal(node); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Though type casting fromLeetCodeNode toIProblem is fine. Let's add getter inLeetCodeNode to get the data, which is typed asIProblem.
It looks like I need to do some refactors here later after this PR, The definition of
LeetCodeNodeandIProblemis overlapped.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
ringcrl commentedFeb 16, 2019
Add tag selector |
jdneo commentedFeb 16, 2019
@ringcrl Looks much better now. I just did some changes and merged the PR. Thank you for your contribution. |
Uh oh!
There was an error while loading.Please reload this page.
add outputPath config for leetcode#119
Change Request,Need Help...Find a way to get a Problem difficulty...