- Notifications
You must be signed in to change notification settings - Fork669
add switchDefaultLanguage#114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Changes fromall commits
File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more abouthow customized files appear on GitHub.
Uh oh!
There was an error while loading.Please reload this page.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -4,10 +4,19 @@ | ||
| import * as vscode from "vscode"; | ||
| import { leetCodeExecutor } from "../leetCodeExecutor"; | ||
| import { IQuickItemEx } from "../shared"; | ||
| import { Endpoint, languages } from "../shared"; | ||
| import { DialogType, promptForOpenOutputChannel, promptForSignIn } from "../utils/uiUtils"; | ||
| import { deleteCache } from "./cache"; | ||
| export async function switchDefaultLanguage(): Promise<void> { | ||
| const leetCodeConfig: vscode.WorkspaceConfiguration = vscode.workspace.getConfiguration("leetcode"); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. The code here is somehow duplicated withhttps://github.com/jdneo/vscode-leetcode/blob/master/src/commands/show.ts#L44-L51 Can we extract them out to share only one piece of code? | ||
| const language: string | undefined = await vscode.window.showQuickPick(languages, { placeHolder: "Select the language you want to use" }); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. If the user has already set a default language, we should at least add a ✅mark before the language. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. I will do it later for I am going to change my job these days. | ||
| if (!language) { | ||
| return; | ||
| } | ||
| leetCodeConfig.update("defaultLanguage", language, true); | ||
| } | ||
| export async function switchEndpoint(): Promise<void> { | ||
| const isCnEnabled: boolean = getLeetCodeEndpoint() === Endpoint.LeetCodeCN; | ||
| const picks: Array<IQuickItemEx<string>> = []; | ||