Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Minor update to Deep Learning Parser example notebook#56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

Jim-Salmons
Copy link
Contributor

The current version of the Deep Learning Parsing example Notebook lacks theinplace=True parameter on thesort method call to the Layout instance in the left Interval. The master version's large block of image data shows these TextBlock's ids in top-down sequential order. Running the Notebook as written, however, will refresh the Notebook page image with out of sequence ids due to the default of theinplace parameter being False. The current master Notebook will produce the following image post-refresh:
actual-dlp-example-img
For instructional clarity, this version also casts theright_blocks variable as aLayout instance initialized with theTextBlock instances not in the leftInterval and withinplace=True to ensure the intendedsort sequencing of block ids.

A few non-essential additions to the source comments are added relative to the changes described.

Please note: At 70 years of age, this is my first PR to a public repository. I started my career with no CompSci or engineering experience as a Control Data PLATO developer. I then spent the bulk of my career in Programmer Nirvana as a Smalltalk developer on small teams with brilliant engineers who did all the necessary heavy lifting of integration and testing while I got to explore the nether regions of proof-of-concept ideas. So this is truly a learning experience for me. Any pointers or advice to make this PR useful and acceptable will be greatly appreciated.

The current version of the Deep Learning Parsing example Notebook lacks the 'inplace=True' parameter on the sort method call to the Layout instance in the left Interval. This version's large block of image data shows these TextBlock's ids in top-down sequential order. Running the Notebook as written, however, will refresh the Notebook page image with out of sequence ids due to the default of the inplace parameter being False.For instructional clarity, this version casts the right_blocks variable as a Layout instance initialized with the TextBlocks not in the left Interval and with inplace=True.A few non-essential additions to the source comments are added relative to the changes described.
The current version of the Deep Learning Parsing example Notebook lacks the 'inplace=True' parameter on the sort method call to the Layout instance in the left Interval. This version's large block of image data shows these TextBlock's ids in top-down sequential order. Running the Notebook as written, however, will refresh the Notebook page image with out of sequence ids due to the default of the inplace parameter being False.For instructional clarity, this version casts the right_blocks variable as a Layout instance initialized with the TextBlocks not in the left Interval and with inplace=True.A few non-essential additions to the source comments are added relative to the changes described.
@lolipopshock
Copy link
Member

lolipopshock commentedJan 12, 2022
edited
Loading

Thank you for the updates,@Jim-Salmons ! I added some minor tweaks to your updates to minimize the unnecessary/hidden Jupyter Notebook changes. But other than that all looks great!

@lolipopshocklolipopshock merged commit6651da5 intoLayout-Parser:masterJan 12, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@Jim-Salmons@lolipopshock

[8]ページ先頭

©2009-2025 Movatter.jp