Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

initial idea on a dbtool#185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
christianparpart wants to merge2 commits intomaster
base:master
Choose a base branch
Loading
fromfeature/dbtool
Draft

Conversation

@christianparpart
Copy link
Member

@christianparpartchristianparpart commentedJan 22, 2025
edited
Loading

This pull request introduces several enhancements and refactors to the SQL schema handling, debugging configuration, and type definitions in the codebase. The key changes include adding a new debugging configuration forvimspector, refactoring schema-related functions to useSqlConnection for better encapsulation, introducing a utility function for mapping ODBC data types, and improving type safety in migration plans.

Debugging Enhancements:

  • .vimspector.json: Added a new debugging configuration fordbtool to enable launching and debugging thedbtool program with predefined arguments and settings.

Schema Handling Refactors:

  • src/Lightweight/SqlSchema.cpp: Refactored schema-related functions (ReadAllTables,AllTables, etc.) to useSqlConnection instead of raw database and schema strings for improved encapsulation and clarity. Added logging for SQL execution and ensured cursors are closed after use.[1][2][3]
  • src/Lightweight/SqlSchema.hpp: Updated function signatures to reflect the use ofSqlConnection in schema-related functions.[1][2]

Type Mapping Improvements:

  • src/Lightweight/SqlColumnTypeDefinitions.hpp: Introduced theMakeColumnTypeFromNative function to map ODBC data types toSqlColumnTypeDefinition in a concise and reusable way. This replaces the previous implementation that was scattered across multiple files.
  • src/Lightweight/SqlSchema.cpp: Replaced the oldFromNativeDataType implementation with the newMakeColumnTypeFromNative utility for better maintainability and consistency.

Migration Plan Improvements:

Logging and Error Handling:

These changes improve the maintainability, debugging capabilities, and robustness of the codebase, particularly in handling SQL schema operations and type mappings.

@github-actionsgithub-actionsbot added CLIcommand line interface tools ddl2cpp Query Builder Core API labelsJan 22, 2025
@christianparpartchristianparpartforce-pushed thefeature/dbtool branch 2 times, most recently from9af1aac to010c539CompareJanuary 23, 2025 21:30
@christianparpartchristianparpartforce-pushed thefeature/dbtool branch 2 times, most recently froma1b24d0 to9de17adCompareJanuary 26, 2025 19:37
@christianparpartchristianparpartforce-pushed thefeature/dbtool branch 5 times, most recently from0f4ce0e todc74b9eCompareFebruary 6, 2025 22:08
… public APISigned-off-by: Christian Parpart <christian@parpart.family>
Signed-off-by: Christian Parpart <christian@parpart.family>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLIcommand line interface toolsCore APIddl2cppQuery Buildertests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@christianparpart

[8]ページ先頭

©2009-2025 Movatter.jp