- Notifications
You must be signed in to change notification settings - Fork39
Add JLArrays, Metal and AMDGPU extensions and S kwarg tests (rebased)#351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Co-authored-by: Dominique <dominique.orban@gmail.com>
Co-authored-by: Dominique <dominique.orban@gmail.com>
dpo commentedOct 16, 2024
@nHackel It looks like there's a dependency issue with Julia 1.6 (that should perhaps be abandoned at this point), and a test error with Julia 1:https://github.com/JuliaSmoothOptimizers/LinearOperators.jl/actions/runs/11375178950/job/31645355758?pr=351#step:6:495 |
nHackel commentedOct 17, 2024
I'll try to fix the test issue over the weekend. W can probably bump the compat to 1.10 since that is the new LTS |
nHackel commentedNov 1, 2024
@dpo if we want to update from LTS 1.6 to the current LTS 1.10, should we do that in a seperate PR? I've also looked into the test failure and for me it only happens in a 1.11 version and it seems like the SymTriDiagonal array and its LinearOperator don't work for GPU arrays anyways. At least they didnt work for JLArrays and CuArrays when I tested it |
dpo commentedNov 22, 2024
nHackel commentedNov 22, 2024
@dpo I don't have permission to edit this branch, but maybe I oversaw something. I've fetched this branch to my fork and made a new PR to this branch with the test commented out. If there is a way that is more straightforward or convenient for you, let me know and I update it |
42e4e36 intomainUh oh!
There was an error while loading.Please reload this page.
dpo commentedNov 23, 2024
Many thanks@nHackel ! |
No description provided.