- Notifications
You must be signed in to change notification settings - Fork39
Add S kwarg toopRestriction#324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
|
geoffroyleconte left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you!
dpo left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This looks good, thank you!
For my own information, what shouldS be in your example in#323?
nHackel commentedApr 30, 2024
@dpo in that case it should have been a |
This PR adds the
Skeyword to theopRestrictionconstructor. Thisfixes#323.Since the operator has no type information of the storage type for a default cause of
S = Vector{T}as other operators ahve, I've opted to give him a default of nothing. IfSis nothing the normal operator is called, which will have a storage type ofVector{Int64}.I did not add a
opRestriction(...; kwargs...)for the constructors which fall back on other operators, since at a quick glance I didn't see such a pattern used in this package.