Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.7k
Backports for 1.12.3#60225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
KristofferC wants to merge11 commits intorelease-1.12Choose a base branch frombackports-release-1.12
base:release-1.12
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Backports for 1.12.3#60225
+201 −102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…e now stdlibs (#60061)This helps handling manifest from earlier julia versions. This is kindof the `locate` version of the `identify` fallback in#56148.Need to write a test when this happens (and verify that this fix works).Noted in a slack #gripes comment.---------Co-authored-by: KristofferC <kristoffer.carlsson@juliacomputing.com>Co-authored-by: Max Horn <max@quendi.de>(cherry picked from commit6fddac8)
When starting julia, `Base.Filesystem.TEMP_CLEANUP` should be empty,but is being left with these two files. The proposed fix is to set uptemporary files created by function `generate_precompile_statements` in`contrib/generate_precompile.jl` to have no automatic cleanup. Thiswon't do harm since they will be removed by the cleanup of thetemporary directory created by the call to `mktempdir` in function`generate_precompile_statements` (see the call `rm(tmpdir,recursive=true)` in `base/file.jl`). These should be removed by theatexit hook, but we didn't run `Base.__init__` or`Base.Filesystem.__postinit__` hooks to re-register this cleanuphandler in the sys.so generation process (only in sysbase.so).To test this issue, one can do:`$ mkdir $TMPDIR/JuliaBuild``$ OLDTMPDIR=$TMPDIR``$ export TMPDIR=$TMPDIR/JuliaBuild``$ cd <julia's build root>``$ <build julia>``$ strings usr/lib/julia/sys.dylib|less # shows that the temp. dir.JuliaBuild is hardcoded in the binaries``$ TMPDIR=$OLDTMPDIR``$ chmod u-x $TMPDIR/JuliaBuild``$ <run the built julia with ./julia and exit> # should try to use$TMPDIR/JuliaBuild which is now inaccessible`Without the fix, the last step triggers the infinite loop of ``Failed toclean up temporary path''. With the fix, one can see that the binaries(`usr/lib/julia/sys.dylib`) do not contain the temp. dir. anymore, andthe infinite loop of errors is not triggered.Or simply by observing that `./julia -E 'Base.Filesystem.TEMP_CLEANUP'`is not empty.Fix#60078(cherry picked from commit1eea4b6)
Member
fingolfin commentedNov 24, 2025
Should this PR be renamed to something indicating this is a general backport PR? |
MemberAuthor
KristofferC commentedNov 24, 2025
Thanks, sometimes it auto populate the title with the first commit or something and I didn't notice. |
p-r-o-g commentedNov 24, 2025
But for 1.12.3, right? |
This PR addresses an issue with `IOError` not being exported from `Base`and therefore being unavailable within `Random` if not fully qualified.I'm not entirely certain which branch to make this PR to: `release-1.12`or `backports-release-1.12`. Please change the target branch to theappropriate one if necessary.
Contributor
araujoms commentedNov 27, 2025
Can I help with#59991? For some reason it didn't make it into 1.12.2 and I kind of need it. |
Not sure if this is the best approach but seemed to allow Mmap test topass. Seems the pagesize was being set to value at build-time ratherthan being re-evaluated at runtime. Running Mmap tests on system with64k pagesize, Mmap would still think its on a system with 4k pagesizeand therefore fail.---------Co-authored-by: Jameson Nash <vtjnash@gmail.com>(cherry picked from commitdb003be)
Thanks to PermutationGroups.jl for dog-fooding our typos! This nowmatches the runtime implementation in datatype.c (setonce_bits) andensures that we properly compute the success bit. The test that wasintended to check for this is now written to inline that struct and thusactually test for this (undef fields are not eligible for inlining).Fix#59883(cherry picked from commitc5553c9)
(cherry picked from commit8795edd)
cff8e13 to11014f6CompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Backported PRs:
Need manual backport:
Contains multiple commits, manual intervention needed:
Non-merged PRs with backport label:
inline_cost_threshold == typemax(Int)#60121Core._apply_iterate#60062