Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add JuliaLang/JuliaSyntax.jl#525 to NEWS.md, flisp parser, and REPL#57143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
oscardssmith merged 4 commits intoJuliaLang:masterfrompthariensflame:patch-2
May 14, 2025

Conversation

@pthariensflame
Copy link
Contributor

@pthariensflamepthariensflame commentedJan 23, 2025•
edited
Loading

Now thatJuliaLang/JuliaSyntax.jl#525 has been merged, also add it to the flisp parser and REPL, and document it!

@Keno
Copy link
Member

Also needs to be added in the flisp parser and needs to wait for the JuliaSyntax version bump.

pthariensflame reacted with thumbs up emoji

@nsajkonsajko added the docsThis change adds or pertains to documentation labelJan 23, 2025
@pthariensflamepthariensflame changed the titleAdd JuliaLang/JuliaSyntax.jl#525 to NEWS.mdAdd JuliaLang/JuliaSyntax.jl#525 to NEWS.md and flisp parserJan 24, 2025
@pthariensflame
Copy link
ContributorAuthor

@Keno@nsajko This PR now also adds support for U+1F8B2 🢲 to the flisp parser and with it the Base id char functions.

@pthariensflamepthariensflameforce-pushed thepatch-2 branch 2 times, most recently from8720f42 tof4d279aCompareJanuary 24, 2025 23:11
@nsajkonsajko added parserLanguage parsing and surface syntax featureIndicates new feature / enhancement requests needs testsUnit tests are required for this change and removed docsThis change adds or pertains to documentation labelsJan 25, 2025
@nsajko
Copy link
Member

I'm guessing this PR will also need tests, so I added the label.

@pthariensflame
Copy link
ContributorAuthor

@nsajko I'm not sure what to test; I can't find any tests for the other arrow operators that already exist.

@pthariensflamepthariensflame changed the titleAdd JuliaLang/JuliaSyntax.jl#525 to NEWS.md and flisp parserAdd JuliaLang/JuliaSyntax.jl#525 to NEWS.md, flisp parser, and REPLFeb 1, 2025
@nsajko
Copy link
Member

I'd write a simple test like this one:

@testset"RIGHTWARDS ARROW WITH LOWER HOOK"begin    🢲(l, r)=2l+3r@test5=== (1 🢲1)end

Perhaps also something to test its operator precedence?

Something like this could be fine, too:

julia/test/syntax.jl

Lines 2274 to 2280 in9a278a2

# issue 45962
@testset"binary ⭄, ⥺, ⭃, and ⥷"begin
@test Meta.parse("a ⭄ b")==Expr(:call, :⭄,:a,:b)
@test Meta.parse("a ⥺ b")==Expr(:call, :⥺,:a,:b)
@test Meta.parse("a ⭃ b")==Expr(:call, :⭃,:a,:b)
@test Meta.parse("a ⥷ b")==Expr(:call, :⥷,:a,:b)
end

@pthariensflame
Copy link
ContributorAuthor

@nsajko Added something based on your second example and the others in that file.

nsajko reacted with thumbs up emoji

@nsajkonsajko removed the needs testsUnit tests are required for this change labelFeb 3, 2025
@pthariensflame
Copy link
ContributorAuthor

Is this ready to merge or are we still waiting onJuliaLang/JuliaSyntaxHighlighting.jl#9 and its followups?

@pthariensflame
Copy link
ContributorAuthor

@Keno Since the branch just happened: is this able to get in for Julia 16 after all, or do we need to undo the JuliaSyntax change that’s already included in 1.0?

@KenoKeno added the backport 1.12Change should be backported to release-1.12 labelFeb 6, 2025
@Keno
Copy link
Member

Keno commentedFeb 6, 2025

It'll be added to the release branch after merge. There's a couple of other PRs in the same boat

pthariensflame reacted with thumbs up emoji

@KristofferCKristofferC mentioned this pull requestFeb 26, 2025
This was referencedMar 24, 2025
@KristofferCKristofferC mentioned this pull requestApr 4, 2025
51 tasks
@KristofferCKristofferC mentioned this pull requestApr 29, 2025
53 tasks
@KristofferCKristofferC mentioned this pull requestMay 9, 2025
58 tasks
@pthariensflame
Copy link
ContributorAuthor

Any news on what needs to happen to merge this?

@nsajko
Copy link
Member

There are conflicts.

@pthariensflame
Copy link
ContributorAuthor

@nsajko Conflicts resolved!

nsajko reacted with rocket emoji

@pthariensflamepthariensflameforce-pushed thepatch-2 branch 2 times, most recently from9a59687 toeacd31dCompareMay 13, 2025 02:51
@oscardssmithoscardssmith merged commit229a698 intoJuliaLang:masterMay 14, 2025
7 checks passed
@pthariensflamepthariensflame deleted the patch-2 branchMay 14, 2025 22:05
@KristofferCKristofferC mentioned this pull requestJun 6, 2025
60 tasks
@pthariensflame
Copy link
ContributorAuthor

Was this ever backported to 1.12? I don’t see it in the merged 1.12 rc1 PR (#58655) but it’s been dropped from consideration for the rc2 backport PR (#59006).

@nsajko
Copy link
Member

Doesn't seem to be present in v1.12 NEWS.md:

https://docs.julialang.org/en/v1.12-dev/NEWS/

@KristofferCKristofferC mentioned this pull requestJul 22, 2025
20 tasks
@KristofferCKristofferC mentioned this pull requestAug 6, 2025
38 tasks
@KristofferCKristofferC mentioned this pull requestAug 19, 2025
27 tasks
This was referencedSep 24, 2025
@KristofferCKristofferC mentioned this pull requestOct 21, 2025
35 tasks
@KristofferCKristofferC mentioned this pull requestNov 24, 2025
23 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backport 1.12Change should be backported to release-1.12featureIndicates new feature / enhancement requestsparserLanguage parsing and surface syntax

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pthariensflame@Keno@nsajko@oscardssmith
[8]ページ先頭
©2009-2025 Movatter.jp