Commit0de49fb

authored and

committed

Skip executors that fail withArgumentError

Instead of passing the error up to the toplevel, in case some other executorworks.

1 parent736faf5 commit0de49fbCopy full SHA for 0de49fb

File tree

+12

-1

lines changed

+12

-1

lines changed

Lines changed: 12 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -180,7 +180,18 @@ function probe_executor(executor::SandboxExecutor; verbose::Bool = false)`
`180`	`180`
`181`	`181`	`# Command should execute successfully`
`182`	`182`	`user_cmd=ignorestatus(user_cmd)`
`183`		`-if!success(run(executor, config, user_cmd))`
	`183`	`+ proc=try`
	`184`	`+run(executor, config, user_cmd)`
	`185`	`+catch e`
	`186`	`+ifisa(e, ArgumentError)`
	`187`	`+if verbose`
	`188`	`+@warn("Unable to build executor command:", e.msg)`
	`189`	`+end`
	`190`	`+returnfalse`
	`191`	`+end`
	`192`	`+rethrow(e)`
	`193`	`+end`
	`194`	`+if!success(proc)`
`184`	`195`	`if verbose`
`185`	`196`	`cmd_stdout=String(take!(cmd_stdout))`
`186`	`197`	`cmd_stderr=String(take!(cmd_stderr))`

Comments

(0)