- Notifications
You must be signed in to change notification settings - Fork14
[WIP] Types extension#158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
MartinuzziFrancesco wants to merge1 commit intoJuliaAI:devChoose a base branch
base:dev
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Contributor
adienes commentedMar 11, 2024
why introduce an argument rather than using the type of |
Author
MartinuzziFrancesco commentedMar 11, 2024
yes there are a lot of redundancies at the moment, I started this top down while I was digging into the code instead of bottom up. I'll be fixing a lot of these in the next push |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is meant to extend the package to return output with matching typing of the given input data. Specifically I am adding the flexibility to all functions to handle
Float64as well asFloat32andFloat16.This is PR is a heavy work in progress at the moment, I'm mercilessly dispatching on all functions that need changing, but I think at the end there's going to be redundant code, I'll sweep through everything at the end.
Tentative (and living) checklist of stuff to add
fitfolder functionsglrfolder functions (underway)mljfolder functions