Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore(deps): update dependency path-to-regexp to v6.3.0 [security]#373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
renovate wants to merge1 commit intomaster
base:master
Choose a base branch
Loading
fromrenovate/npm-path-to-regexp-vulnerability

Conversation

@renovate
Copy link
Contributor

@renovaterenovatebot commentedSep 10, 2024
edited
Loading

This PR contains the following updates:

PackageChangeAgeConfidence
path-to-regexp6.2.1 ->6.3.0ageconfidence

GitHub Vulnerability Alerts

CVE-2024-45296

Impact

A bad regular expression is generated any time you have two parameters within a single segment, separated by something that is not a period (.). For example,/:a-:b.

Patches

For users of 0.1, upgrade to0.1.10. All other users should upgrade to8.0.0.

These versions add backtrack protection when a custom regex pattern is not provided:

They do not protect against vulnerable user supplied capture groups. Protecting against explicit user patterns is out of scope for old versions and not considered a vulnerability.

Version7.1.0 can enablestrict: true and get an error when the regular expression might be bad.

Version8.0.0 removes the features that can cause a ReDoS.

Workarounds

All versions can be patched by providing a custom regular expression for parameters after the first in a single segment. As long as the custom regular expression does not match the text before the parameter, you will be safe. For example, change/:a-:b to/:a-:b([^-/]+).

If paths cannot be rewritten and versions cannot be upgraded, another alternative is to limit the URL length. For example, halving the attack string improves performance by 4x faster.

Details

Using/:a-:b will produce the regular expression/^\/([^\/]+?)-([^\/]+?)\/?$/. This can be exploited by a path such as/a${'-a'.repeat(8_000)}/a.OWASP has a good example of why this occurs, but the TL;DR is the/a at the end ensures this route would never match but due to naive backtracking it will still attempt every combination of the:a-:b on the repeated 8,000-a.

Because JavaScript is single threaded and regex matching runs on the main thread, poor performance will block the event loop and can lead to a DoS. In local benchmarks, exploiting the unsafe regex will result in performance that is over 1000x worse than the safe regex. In a more realistic environment using Express v4 and 10 concurrent connections, this translated to average latency of ~600ms vs 1ms.

References


Release Notes

pillarjs/path-to-regexp (path-to-regexp)

v6.3.0: Fix backtracking in 6.x

Compare Source

Fixed

v6.2.2: Updated README

Compare Source

No API changes. Documentation only release.

Changed


Configuration

📅Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦Automerge: Enabled.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated byMend Renovate. View therepository job log.

@renovate
Copy link
ContributorAuthor

renovatebot commentedSep 10, 2024
edited
Loading

⚠️ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: yarn.lock
/opt/containerbase/tools/corepack/0.34.5/16.20.2/node_modules/corepack/dist/lib/corepack.cjs:22572  const isURL = URL.canParse(range);                    ^TypeError: URL.canParse is not a function    at parseSpec (/opt/containerbase/tools/corepack/0.34.5/16.20.2/node_modules/corepack/dist/lib/corepack.cjs:22572:21)    at Object.getSpec (/opt/containerbase/tools/corepack/0.34.5/16.20.2/node_modules/corepack/dist/lib/corepack.cjs:22721:55)    at Engine.findProjectSpec (/opt/containerbase/tools/corepack/0.34.5/16.20.2/node_modules/corepack/dist/lib/corepack.cjs:22939:31)    at async Engine.executePackageManagerRequest (/opt/containerbase/tools/corepack/0.34.5/16.20.2/node_modules/corepack/dist/lib/corepack.cjs:22978:24)    at async Object.runMain (/opt/containerbase/tools/corepack/0.34.5/16.20.2/node_modules/corepack/dist/lib/corepack.cjs:23684:7)

@vercel
Copy link

vercelbot commentedSep 10, 2024
edited
Loading

The latest updates on your projects. Learn more aboutVercel for Git ↗︎

NameStatusPreviewCommentsUpdated (UTC)
react-hackernews❌ Failed (Inspect)Sep 11, 2024 6:19pm

@changeset-bot
Copy link

changeset-botbot commentedSep 10, 2024
edited
Loading

⚠️ No Changeset found

Latest commit:8833969

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go.If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@renovaterenovatebot changed the titlefix(deps): update dependency path-to-regexp to v8 [security]fix(deps): update dependency path-to-regexp to v8 [security] - autoclosedSep 11, 2024
@renovaterenovatebot closed thisSep 11, 2024
@renovaterenovatebot deleted the renovate/npm-path-to-regexp-vulnerability branchSeptember 11, 2024 17:32
@renovaterenovatebot changed the titlefix(deps): update dependency path-to-regexp to v8 [security] - autoclosedfix(deps): update dependency path-to-regexp to v8 [security]Sep 11, 2024
@renovaterenovatebot reopened thisSep 11, 2024
@renovaterenovatebot restored the renovate/npm-path-to-regexp-vulnerability branchSeptember 11, 2024 18:19
@renovaterenovatebotforce-pushed therenovate/npm-path-to-regexp-vulnerability branch fromda5e15a to8833969CompareSeptember 11, 2024 18:19
@renovaterenovatebotenabled auto-merge (rebase)September 12, 2024 17:41
@renovaterenovatebot changed the titlefix(deps): update dependency path-to-regexp to v8 [security]fix(deps): update dependency path-to-regexp to v6.3.0 [security]Sep 12, 2024
@renovaterenovatebot changed the titlefix(deps): update dependency path-to-regexp to v6.3.0 [security]chore(deps): update dependency path-to-regexp to v6.3.0 [security]Sep 25, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

0 participants


[8]ページ先頭

©2009-2025 Movatter.jp