Update vue-numeric-input.vue#5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

Trigur wants to merge1 commit intoJayeshLab:master

base:master

Choose a base branch

fromTrigur:patch-1

Open

Update vue-numeric-input.vue#5

Trigur wants to merge1 commit intoJayeshLab:masterfromTrigur:patch-1

Conversation

Copy link

Trigur commentedFeb 5, 2019

Fix NaN when value is empty

Update vue-numeric-input.vue

3b2e066

Copy link

codecov-io commentedFeb 5, 2019

Codecov Report

Merging#5 intomaster willnot change coverage.
The diff coverage is100%.

@@           Coverage Diff           @@##           master       #5   +/-   ##=======================================  Coverage   96.42%   96.42%           =======================================  Files           1        1             Lines          56       56             Branches       16       16           =======================================  Hits           54       54             Partials        2        2

Impacted Files	Coverage Δ
src/vue-numeric-input.vue	`96.42% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update5d7a184...3b2e066. Read thecomment docs.

Copy link

MartinKleikamp commentedFeb 28, 2019

Why this is closed? I do not find the merge in master. In my opinion this resolves a valid issue with initial null values, as consequence you have to click twice on + or - initially. I tested this pull request successfully.