Commit56a96d8

authored and

committed

VREffect and VRControls: Catch error retreiving VR Displays (mrdoob#9825)

This can happen if the page is inside an iframe that doesn't have an `allowvr` attribute set or if permission is otherwise denied.

1 parent18a33bd commit56a96d8Copy full SHA for 56a96d8

File tree

+10

-2

lines changed

+10

-2

lines changed

Lines changed: 5 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,11 @@ THREE.VRControls = function ( object, onError ) {`
`37`	`37`
`38`	`38`	`if(navigator.getVRDisplays){`
`39`	`39`
`40`		`-navigator.getVRDisplays().then(gotVRDisplays);`
	`40`	`+navigator.getVRDisplays().then(gotVRDisplays).catch(function(){`
	`41`	`+`
	`42`	`+console.warn('THREE.VRControls: Unable to get VR Displays');`
	`43`	`+`
	`44`	`+});`
`41`	`45`
`42`	`46`	`}`
`43`	`47`

Lines changed: 5 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,11 @@ THREE.VREffect = function ( renderer, onError ) {`
`42`	`42`
`43`	`43`	`if(navigator.getVRDisplays){`
`44`	`44`
`45`		`-navigator.getVRDisplays().then(gotVRDisplays);`
	`45`	`+navigator.getVRDisplays().then(gotVRDisplays).catch(function(){`
	`46`	`+`
	`47`	`+console.warn('THREE.VREffect: Unable to get VR Displays');`
	`48`	`+`
	`49`	`+});`
`46`	`50`
`47`	`51`	`}`
`48`	`52`

Comments

(0)