Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

release: v1.5.0#59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
albin3 merged 2 commits intomasterfromfeat-placeholder-support
Oct 31, 2023
Merged

release: v1.5.0#59

albin3 merged 2 commits intomasterfromfeat-placeholder-support
Oct 31, 2023

Conversation

albin3
Copy link
Member

No description provided.

@cctv1005s
Copy link
Collaborator

  1. in test file, the caseplace holder support andplace holder support2 are almost the same, what's the difference between the 2 cases, I mean, maybeplace holder support2 is not necessary.

  2. It seems the syntax only support some sql likeselect ${a} from b rather thanselect a from ${a}. If that's intentional,, I think you could make it more clear in the README.

@albin3
Copy link
MemberAuthor

@cctv1005s

  1. place holder support2 put placeholder into quotation, it's testing placeholder feature should not affect normal use of$.

  2. since table_name is anIDENTIFIER, it's not supported yet. Will add this info to readme.

@cctv1005s
Copy link
Collaborator

Okay, lGTM

@albin3albin3 merged commitdec1f54 intomasterOct 31, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@cctv1005scctv1005scctv1005s approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@albin3@cctv1005s

[8]ページ先頭

©2009-2025 Movatter.jp