NotificationsYou must be signed in to change notification settings
Fork47
Star256

feat(): unicode extended char support for column name or alias#58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

albin3 merged 2 commits intoJavaScriptor:masterfromluizzappa:unicode-extended

Nov 5, 2023

Merged

feat(): unicode extended char support for column name or alias#58

albin3 merged 2 commits intoJavaScriptor:masterfromluizzappa:unicode-extended

Nov 5, 2023

Conversation

Copy link

Contributor

luizzappa commentedOct 22, 2023

Currently, you cannot name (or alias) a column with certain Latin characters without using quotes, even though this is supported byMySQL syntax. In this PR, I added this.

Parser error:

MySQL syntax:

Permitted characters in unquoted identifiers:- ASCII: [0-9,a-z,A-Z$_] (basic Latin letters, digits 0-9, dollar, underscore)- Extended: U+0080 .. U+FFFF

luizzappa force-pushed theunicode-extended branch 2 times, most recently from31faa6a toc4b243eCompare

October 22, 2023 18:20

Copy link

ContributorAuthor

luizzappa commentedOct 22, 2023

Sorry for the force, there was code that wasn't supposed to be committed

albin3 added the bug label

Oct 31, 2023

Copy link

Member

albin3 commentedOct 31, 2023

hi,@luizzappa thanks for the pr, it is a serious problem. Could you update this pr like this:

I think there is no need to modify lines insrc/sqlParser.jison which logic is not modified. It will increase review or blame cost in the future.
It seems[a-zA-Z0-9_\u0080-\uFFFF]* return 'IDENTIFIER' is a better pattern, will fix this issue these days.

luizzappa added2 commits

November 2, 2023 17:46

feat(): unicode extended char support for column name or alias

199a1c6

Merge branch 'master' of github.com:JavaScriptor/js-sql-parser into u…

1064642

…nicode-extended

luizzappa force-pushed theunicode-extended branch from3ff5bc5 to1064642Compare

November 2, 2023 20:53

Copy link

ContributorAuthor

luizzappa commentedNov 2, 2023

@albin3, Done. In my first commit I had indented the other lines to maintain the formatting, with this smaller pattern suggested by you I didn't need to do that, thanks.

https://github.com/JavaScriptor/js-sql-parser/compare/master..10646422beaee247db28c171ca791f2880253a19