Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Broken build due to import#22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
albin3 merged 1 commit intoJavaScriptor:masterfrommichaelmior:fix-import
Jul 25, 2019
Merged

Broken build due to import#22

albin3 merged 1 commit intoJavaScriptor:masterfrommichaelmior:fix-import
Jul 25, 2019

Conversation

michaelmior
Copy link
Contributor

@michaelmiormichaelmior commentedJul 23, 2019
edited
Loading

There is currently an unusedimport statement which ends up appearing in the built parser. With the latest release of this module, this breaks my code sinceimport statements aren't directly supported. In general, this could be handled by preprocessing with something like Babel, but in this case, the import wasn't actually used so I just removed it.

Would be great if another release could be made after this is merged :)`

@michaelmiormichaelmior changed the titleThere is currently an unusedimport statement which ends up appearing in the built parser. With the latest release of this module, this breaks my code sinceimport statements aren't directly supported. In general, this could be handled by preprocessing with something like Babel, but in this case, the import wasn't actually used so I just removed it.Broken build due to importJul 23, 2019
@michaelmior
Copy link
ContributorAuthor

Please excuse the typo which caused the horribly long initial title.

@albin3albin3 merged commit1da1a6b intoJavaScriptor:masterJul 25, 2019
@albin3
Copy link
Member

@michaelmior sorry for the typo.

new version: v1.1.0 has released to fix this issue.

It's probably caused by my typo when editing "travel". When I type "ti" in vscode, and it just addimport { timingSafeEqual } from "crypto" in the head of the file.

Will add test case to check these case before release.

@michaelmior
Copy link
ContributorAuthor

No problem. Thanks for the fix!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@michaelmior@albin3

[8]ページ先頭

©2009-2025 Movatter.jp