Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Implement INSERT and UPDATE parsing#10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
gpittarelli wants to merge3 commits intoJavaScriptor:master
base:master
Choose a base branch
Loading
fromgpittarelli:master

Conversation

gpittarelli
Copy link

@gpittarelligpittarelli commentedApr 10, 2018
edited
Loading

Implements parsing for INSERT and UPDATE queries, per the MySQL 5.7 grammar. Includes pretty printing + test cases.

(Note: for my own purposes, I've published this branch under@gpittarelli/js-sql-parser)

@albin3
Copy link
Member

Great, i'm a little busy these days, i will review it later.

@albin3
Copy link
Member

hi,@gpittarelli .

I reviewed theinsert part in this pr and there are something need to change / some questions need to confirm:

  1. followinghttps://dev.mysql.com/doc/refman/5.7/en/insert.html ,simple_table_factor grammar may be should be replaced byidentifier.
  2. more test cases are needed for for the new code.
  3. suggestion: format the code more similar with document inhttps://dev.mysql.com/doc/refman/5.7/en/insert.html , such as there are three insert grammars in document, we also write it into three lines. So, it's more readable.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@gpittarelli@albin3

[8]ページ先頭

©2009-2025 Movatter.jp