Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: add support for quoted alias#33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
albin3 merged 1 commit intoJavaScriptor:masterfromTrackTik:master
Mar 30, 2020
Merged

feat: add support for quoted alias#33

albin3 merged 1 commit intoJavaScriptor:masterfromTrackTik:master
Mar 30, 2020

Conversation

eortiz-tracktik
Copy link
Contributor

We are using this parser and we would like to be able to use quoted alias like on the tests.
Basically, anything quoted should be safe as a quoted identifier?

Thanks.

@albin3
Copy link
Member

@eortiz-tracktik
Copy link
ContributorAuthor

@albin3 thanks for the quick response.
We have tried to use it, but is limited to some specific characters and we can't use some of the special characters we have put on the tests.

  it('support quoted alias', function() {    testParser('select a as `A-A` from b limit 2;');    testParser('select a as `A#A` from b limit 2;');    testParser('select a as `A?A` from b limit 2;');    testParser('select a as `A/B` from b limit 2;');    testParser('select a as `A.A` from b limit 2;');    testParser('select a as `A|A` from b limit 2;');    testParser('select a as `A A` from b limit 2;');  });

I saw that there was already the concept of QUOTED_IDENTIFIER but was also limited to certain characters.
I understand why we need to limit the allowed characters on regular identifiers, but if it's quoted I think we don't need to have this restriction.

albin3 reacted with thumbs up emoji

@albin3albin3 merged commitbb66951 intoJavaScriptor:masterMar 30, 2020
@albin3
Copy link
Member

@eortiz-tracktik you are right! thanks for this pr. 😺

@albin3
Copy link
Member

v1.2.2 has released.

eortiz-tracktik reacted with thumbs up emoji

@eortiz-tracktik
Copy link
ContributorAuthor

Thanks a lot to you@albin3 for this awesome project! 👏

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@eortiz-tracktik@albin3

[8]ページ先頭

©2009-2025 Movatter.jp