Commite0e68c2

committed

fix(eslint-plugin): [consistent-indexed-object-style] handle circular mapped types

1 parentbce4560 commite0e68c2Copy full SHA for e0e68c2

File tree

+19

-0

lines changed

+19

-0

lines changed

Lines changed: 18 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -176,6 +176,24 @@ export default createRule<Options, MessageIds>({`
`176`	`176`	`return;`
`177`	`177`	`}`
`178`	`178`
	`179`	`+// If the mapped type is circular, we can't convert it to a Record.`
	`180`	`+constparentId=findParentDeclaration(node)?.id;`
	`181`	`+if(parentId){`
	`182`	`+constscope=context.sourceCode.getScope(key);`
	`183`	`+constsuperVar=ASTUtils.findVariable(scope,parentId.name);`
	`184`	`+if(superVar){`
	`185`	`+constisCircular=superVar.references.some(`
	`186`	`+item=>`
	`187`	`+item.isTypeReference&&`
	`188`	`+node.range[0]<=item.identifier.range[0]&&`
	`189`	`+node.range[1]>=item.identifier.range[1],`
	`190`	`+);`
	`191`	`+if(isCircular){`
	`192`	`+return;`
	`193`	`+}`
	`194`	`+}`
	`195`	`+}`
	`196`	`+`
`179`	`197`	`// There's no builtin Mutable<T> type, so we can't autofix it really.`
`180`	`198`	`constcanFix=node.readonly!=='-';`
`181`	`199`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -33,6 +33,7 @@ interface Foo {`
`33`	`33`	`'type Foo = { [key: string]: string \| Foo };',`
`34`	`34`	`'type Foo = { [key: string]: Foo };',`
`35`	`35`	`'type Foo = { [key: string]: Foo } \| Foo;',`
	`36`	`+'type Foo = { [key in string]: Foo };',`
`36`	`37`	`
`37`	`38`	`interface Foo {`
`38`	`39`	`[key: string]: Foo;`

Comments

(0)