Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork397
Deploy Previews#645
-
Hi, first of all thank you for this action! I am using this action to deploy my Jekyll site on Since my repo is public, Deploy Previews could be public. Let's say PR requested from branch I think I can do most of it with current capabilities but the action does force push on Thank you. My Merge request action:https://github.com/asynx-dev/www/blob/master/.github/workflows/merge.yml |
BetaWas this translation helpful?Give feedback.
All reactions
Replies: 4 comments
-
Turning off clean and using Keep in mind if the people making the pull requests don't have the required permissions it will throw a permission related error as they may not have access to the tokens it needs to make the requests. |
BetaWas this translation helpful?Give feedback.
All reactions
-
I'm genuinely interested in ways to include generated docs in a review process. One idea I had was for automation to maintain PRs on the That's orthogonal to having a staging site. Though, they share a common problem around finding the right base version of the docs to do a PR for. I think in addition to using a The automation around pruning previews when closing PRs is interesting. I guess none of these steps are actually part of the action. And, handling permissions is gonna be a challenge. I'd totally dig having documentation on best practices, though. |
BetaWas this translation helpful?Give feedback.
All reactions
👍 1
-
Thank you@JamesIves and@Pike for quick responses and ideas. It looks possible to implement the feature using the parameters and the flow you mentioned. One thing remains unclear to me deleting previews of merged PRs as@Pike pointed. I may implement this behaviour with another action likehttps://github.com/marketplace/actions/remove-file For my repository as temporary solution I enabled Netlify integration, it provides deploy previews but 300 min/month limit for free plan can be a bottleneck. |
BetaWas this translation helpful?Give feedback.
All reactions
-
It's been a while, but let me pick up this discussion. I'm currently writing an action to do exactly what is described here. And I'm worried that I'm replicating what is already available in this action. And whatever I'm not replicating will be missing in the end. So maybe it's better to extend this action with missing functionality? There is one puzzle piece missing in the description so far.
That last one is new, so let me explain it: Current workarounds (not verified):
|
BetaWas this translation helpful?Give feedback.