Commitfa0b032

authored

test(eslint-plugin): add missing test cases for rules (typescript-eslint#296)

1 parent9f1d314 commitfa0b032Copy full SHA for fa0b032

File tree

+35

-10

lines changed

+35

-10

lines changed

Lines changed: 3 additions & 10 deletions

Original file line number	Diff line number	Diff line change
`@@ -90,8 +90,6 @@ export default util.createRule({`
`90`	`90`	`consttsQualifier=esTreeNodeToTSNodeMap.get(qualifier);`
`91`	`91`	`consttsName=esTreeNodeToTSNodeMap.get(name);`
`92`	`92`
`93`		`-if(!(tsQualifier&&tsName))returnfalse;// TODO: throw error?`
`94`		`-`
`95`	`93`	`constnamespaceSymbol=checker.getSymbolAtLocation(tsQualifier);`
`96`	`94`
`97`	`95`	`if(`
`@@ -145,16 +143,11 @@ export default util.createRule({`
`145`	`143`	`}`
`146`	`144`
`147`	`145`	`functionenterDeclaration(node:TSESTree.Node):void{`
`148`		`-consttsDeclaration=esTreeNodeToTSNodeMap.get(node);`
`149`		`-if(tsDeclaration){`
`150`		`-namespacesInScope.push(tsDeclaration);`
`151`		`-}`
	`146`	`+namespacesInScope.push(esTreeNodeToTSNodeMap.get(node));`
`152`	`147`	`}`
`153`	`148`
`154`		`-functionexitDeclaration(node:TSESTree.Node){`
`155`		`-if(esTreeNodeToTSNodeMap.has(node)){`
`156`		`-namespacesInScope.pop();`
`157`		`-}`
	`149`	`+functionexitDeclaration(){`
	`150`	`+namespacesInScope.pop();`
`158`	`151`	`}`
`159`	`152`
`160`	`153`	`functionresetCurrentNamespaceExpression(node:TSESTree.Node):void{`

Lines changed: 28 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -40,6 +40,10 @@ ruleTester.run('array-type', rule, {`
`40`	`40`	`code:'let a: Array<{ foo: Array<Bar> }> = []',`
`41`	`41`	`options:['generic']`
`42`	`42`	`},`
	`43`	`+{`
	`44`	+code:`let fooVar: Array;`,
	`45`	`+options:['generic']`
	`46`	`+},`
`43`	`47`	`{`
`44`	`48`	code:`function foo (a: Array<Bar>): Array<Bar> {}`,
`45`	`49`	`options:['generic']`
@@ -622,6 +626,30 @@ let yyyy: Arr<Arr<string>[][]> = [[[["2"]]]];`,
`622`	`626`	`}`
`623`	`627`	`]`
`624`	`628`	`},`
	`629`	`+{`
	`630`	+code:`let fooVar: Array[];`,
	`631`	`+options:['array'],`
	`632`	`+errors:[`
	`633`	`+{`
	`634`	`+messageId:'errorStringArray',`
	`635`	`+data:{type:'any'},`
	`636`	`+line:1,`
	`637`	`+column:13`
	`638`	`+}`
	`639`	`+]`
	`640`	`+},`
	`641`	`+{`
	`642`	+code:`let fooVar: Array[];`,
	`643`	`+options:['array-simple'],`
	`644`	`+errors:[`
	`645`	`+{`
	`646`	`+messageId:'errorStringArraySimple',`
	`647`	`+data:{type:'any'},`
	`648`	`+line:1,`
	`649`	`+column:13`
	`650`	`+}`
	`651`	`+]`
	`652`	`+},`
`625`	`653`	`{`
`626`	`654`	code:`let x: Array<number> = [1] as number[];`,
`627`	`655`	output:`let x: Array<number> = [1] as Array<number>;`,

Lines changed: 4 additions & 0 deletions

Comments

(0)