- Notifications
You must be signed in to change notification settings - Fork48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Remove use of float and math.h#125
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Using pow to square an integer is inappropriate; it results inconversion of integers to and from floats, and a dependency on libm.
Using ceil results in int to float to int conversions and an unnecessarylibm dependency. Also, rename to ceil10 because it rounds up to next 10.Move to wm.c and make static because it is not used anywhere else.
Looks all good to me after some testing. Thanks for including the |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
euclidean_distance and round_k in utils.c use pow and ceil functions from math.h, resulting in int to float to int conversions and an unnecessary dependency on libm. These commits rewrite them using only integer math, move them to wm.c, and make them static for inlining because they are only used there.