This repository was archived by the owner on Feb 2, 2024. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork64
[WIP]: Tweak Int64Index.reindex() performance#984
Open
kozlov-alexey wants to merge2 commits intoIntelPython:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
[WIP]: Tweak Int64Index.reindex() performance#984
kozlov-alexey wants to merge2 commits intoIntelPython:masterfromkozlov-alexey:feature/speedup_int64_index_reindex
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
pep8speaks commentedAug 17, 2021
Hello@kozlov-alexey! Thanks for opening this PR. We checked the lines you've touched forPEP 8 issues, and found:
|
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation: current implementation of Int64Index reindex via building map_positions as a typed.Dict and filling the result indexer in a prange scales poorly and has performance that is far from ideal. This PR improves performance by ~2x by using native TBB based implementation.