This repository was archived by the owner on Feb 2, 2024. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork64
Fixes incorrect definition of layout for SeriesType#1001
Open
kozlov-alexey wants to merge1 commit intoIntelPython:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
pep8speaks commentedDec 21, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Hello@kozlov-alexey! Thanks for updating this PR. We checked the lines you've touched forPEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-12-21 21:53:14 UTC |
df3de6a to8b584c4CompareDetails: definition of underlying data type of Series wasdone from PyObject dtype only and didn't take into accountlayout of original array, as a result 'C' layout was alwaysinferred, where the original array might have other layout,breaking iteration over such Series (DF columns).FixesIntelPython#996.
8b584c4 tob55020dCompareSign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details: definition of underlying data type of Series was
done from PyObject dtype only and didn't take into account
layout of original array, as a result 'C' layout was always
inferred, where the original array might have other layout,
which breaks iteration with such columns.
Fixes#996.