- Notifications
You must be signed in to change notification settings - Fork74
feat(datasets): use scikit-learn datasets downloader#201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
homksei wants to merge1 commit intoIntelPython:mainChoose a base branch fromhomksei:feat-datasets-verify
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Contributor
david-cortes-intel commentedNov 26, 2025
/intelci: run |
Contributor
david-cortes-intel commentedNov 27, 2025
/intelci: run ml-benchmarks |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the dataset downloading mechanism to ensure data integrity by implementing SHA256 checksum verification. It replaces the custom
retrievefunction withsklearn.datasets._base.fetch_file.Changes:
sklbench/datasets/downloaders.py:download_and_read_csvto accept a tuple containing(filename, url, sha256)instead of a raw URL.retrievefunction withsklearn.datasets._base.fetch_fileto handle downloads and hash validation.sklbench/datasets/loaders.py:load_airline_depdelay,load_hepmass,load_higgs,load_sift, etc.) to provide the specific filename, base URL, and corresponding SHA256 hash.load_ann_dataset_templateto support the new metadata structure.Motivation:
To prevent the usage of corrupted or tampered data files and to standardize the downloading logic using scikit-learn's internal utilities.
Checklist:
Completeness and readability
Testing