Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Remove epsilon dataset usage for ml_benchmarks#197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
ethanglaser wants to merge2 commits intomain
base:main
Choose a base branch
Loading
fromdev/eglaser-rm-epsilon

Conversation

@ethanglaser
Copy link
Contributor

@ethanglaserethanglaser commentedNov 12, 2025•
edited
Loading

Description

Avoid ChunkedEncodingError / IncompleteRead issues in CI by disabling usage of epsilon dataset

Checklist:

Completeness and readability

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes or created a separate PR with updates and provided its number in the description, if necessary.
  • Git commit message contains an appropriate signed-off-by string(seeCONTRIBUTING.md for details).
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.
  • I have extended testing suite if new functionality was introduced in this PR.

@ethanglaser
Copy link
ContributorAuthor

@david-cortes-intel
Copy link
Contributor

@razdoburdin Would it be a problem to remove this dataset?

@razdoburdin
Copy link
Collaborator

@razdoburdin Would it be a problem to remove this dataset?

it represents the xgboost cases with large histogram size not fitting in cache, but we can replace it by synthetic data or use preloaded data.

@david-cortes-intel
Copy link
Contributor

@ethanglaser Any blockers for merging this PR?

@ethanglaser
Copy link
ContributorAuthor

ethanglaser commentedNov 26, 2025•
edited
Loading

@ethanglaser Any blockers for merging this PR?

Last I checked there were still some issues with the job. Let's see howhttp://intel-ci.intel.com/f0caf58d-06da-f13b-8936-a4bf010d0e2d goes. Also I think we may need some help from Aleksei, the filters parameter does not work as intended (it always resorts to default from what I can tell)

@david-cortes-intel
Copy link
Contributor

@ethanglaser Any blockers for merging this PR?

Last I checked there were still some issues with the job. Let's see howhttp://intel-ci.intel.com/f0caf58d-06da-f13b-8936-a4bf010d0e2d goes. Also I think we may need some help from Aleksei, the filters parameter does not work as intended (it always resorts to default from what I can tell)

Why would the filters matter if this is removing it from the configs?

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@david-cortes-inteldavid-cortes-inteldavid-cortes-intel approved these changes

@razdoburdinrazdoburdinAwaiting requested review from razdoburdinrazdoburdin will be requested when the pull request is marked ready for reviewrazdoburdin is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ethanglaser@david-cortes-intel@razdoburdin
[8]ページ先頭
©2009-2025 Movatter.jp