Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: enable/disable auto masking screenshots in rn#1389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
kholood-ea merged 15 commits intodevfromRN/Enabling/disbaling-screenshot-auto-masking
May 20, 2025

Conversation

AyaMahmoud148
Copy link
Contributor

Description of the change

Re-merge [RN] enabiling/disabling RN screenshot auto masking

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Issue links go here

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@AyaMahmoud148AyaMahmoud148 changed the base branch frommaster todevMay 14, 2025 10:52
@AyaMahmoud148AyaMahmoud148 changed the titleRn/enabling/disbaling screenshot auto maskingfeat: enable/disable auto masking screenshots in rnMay 14, 2025
@InstabugCI
Copy link
Collaborator

InstabugCI commentedMay 14, 2025•
edited
Loading

Coverage Report

LabelCoverageStatus
JavaScript95.1%✅
Android50.9%✅
iOS51.5%✅

Generated by 🚫dangerJS againstc9b85d3

Copy link
Contributor

@ahmedAlaaInstabugahmedAlaaInstabug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Good job,, we just need to add JS unit tests for enableAutoMasking method

AyaMahmoud148 reacted with thumbs up emoji
@kholood-eakholood-eaenabled auto-merge (squash)May 20, 2025 13:20
@kholood-eakholood-ea merged commit94b5e5b intodevMay 20, 2025
10 of 11 checks passed
@kholood-eakholood-ea deleted the RN/Enabling/disbaling-screenshot-auto-masking branchMay 20, 2025 14:43
MoKamall pushed a commit that referenced this pull requestJun 2, 2025
* feat: enable auto masking screenshots in RN* fix: add change log* fix: add unreleased in changelog* fix: linting* fix: linting* fix: update pod lock* run automask in main thread* fix: linting* fix: linting* fix: update pod lock* fix: add change log* fix: change log lint* fix: linting* add js unit test---------Co-authored-by: Ahmed alaa <aalaa@instabug.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@kholood-eakholood-eakholood-ea approved these changes

@MoKamallMoKamallMoKamall approved these changes

@ahmedAlaaInstabugahmedAlaaInstabugahmedAlaaInstabug approved these changes

@AndrewAminInstabugAndrewAminInstabugAwaiting requested review from AndrewAminInstabug

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@AyaMahmoud148@InstabugCI@kholood-ea@MoKamall@ahmedAlaaInstabug
[8]ページ先頭
©2009-2025 Movatter.jp