- Notifications
You must be signed in to change notification settings - Fork444
🚀 Performance Improvement: Parallelize Session Cleanup with asyncio.gather()#1649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
nmveeresh wants to merge3 commits intomainChoose a base branch fromperf/session-cleanup-asyncio-1616
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+270 −77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Signed-off-by: Veeresh K <veeruveeresh1522@gmail.com>
Signed-off-by: Veeresh K <veeruveeresh1522@gmail.com>
Signed-off-by: Veeresh K <veeruveeresh1522@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR optimizes session cleanup in SessionRegistry by parallelizing database refresh operations using asyncio.gather() instead of executing them sequentially. The change eliminates O(n) cleanup behavior and significantly reduces cleanup latency under high session counts.
❌ Problem
The existing session cleanup logic executed asyncio.to_thread() calls sequentially inside a loop:
With 100 sessions and ~50ms DB latency per session:
✅ Solution
📈 Performance Results
Test output:
Actual parallel cleanup time: 0.438 seconds
Speedup: 11.4x faster than sequential
✅ PASS: Parallel cleanup is significantly faster
🧪 Testing
Run