Commitb5c5655

sidwarkd

and

me-no-dev

authored

Support HTTP 204 (espressif#11408)

HTTP 204 is a successful return code which indicates No Content. While it's appropriate to return a 304 if the server has content for a device but it hasn't change, it is more accurate for a server to return a 204 if it simply doesn't have any firmware files for a particular device.Co-authored-by: Me No Dev <me-no-dev@users.noreply.github.com>

1 parent6f56df2 commitb5c5655Copy full SHA for b5c5655

File tree

1 file changed

-0

lines changed

libraries/HTTPUpdate/src
- HTTPUpdate.cpp

1 file changed

-0

lines changed

`‎libraries/HTTPUpdate/src/HTTPUpdate.cpp‎`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -356,6 +356,7 @@ HTTPUpdateResult HTTPUpdate::handleUpdate(HTTPClient &http, const String &curren`
`356`	`356`	`log_e("Content-Length was 0 or wasn't set by Server?!\n");`
`357`	`357`	`}`
`358`	`358`	`break;`
	`359`	`+case HTTP_CODE_NO_CONTENT:`
`359`	`360`	`case HTTP_CODE_NOT_MODIFIED:`
`360`	`361`	`///< Not Modified (No updates)`
`361`	`362`	`ret = HTTP_UPDATE_NO_UPDATES;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitb5c5655

File tree

1 file changed

1 file changed

`‎libraries/HTTPUpdate/src/HTTPUpdate.cpp‎`

0 commit comments