- Notifications
You must be signed in to change notification settings - Fork3.2k
Add protocol version and encryption configuration to BroadcastService#2011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
SuryaGanesh284 wants to merge1 commit intoHeyPuter:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Add protocol version and encryption configuration to BroadcastService#2011
SuryaGanesh284 wants to merge1 commit intoHeyPuter:mainfromSuryaGanesh284:protocol-versioning-support
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
CLAassistant commentedNov 23, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
|
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds initial support for protocol versioning and configurable encryption strategies to BroadcastService.
What was added
Added protocolVersion_ and encryptionStrategies_ internal fields with default values.
Allowed overriding these values through configuration (config.protocolVersion and config.encryptionStrategies).
Passed the protocol version and encryption strategy options to both CLink and SLink.
Added inline comments explaining the use of protocol versioning and encryption configuration.
Why this is useful
Prepares the broadcast system for future protocol upgrades.
Allows Puter instances to share protocol metadata through connection links.
Establishes a clean path for implementing stronger encryption or backward-compatible protocol changes.
Fully backward-compatible and does not affect existing behavior.
Compatibility
No breaking changes.
Extra fields passed to links are optional and safely ignored if unused.