Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

documentation fixes#2805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
Habbie wants to merge7 commits intoHammerspoon:master
base:master
Choose a base branch
Loading
fromHabbie:docs-fixes
Open

Conversation

@Habbie
Copy link
Contributor

@HabbieHabbie commentedApr 5, 2021
edited
Loading

This PR contains:

  1. a commit that makes build_docs.py more portabl2
  2. a formatting fix for hs.dialog.textPrompt
  3. further commits that fix various things

Many other bits of doc are broken like (2) fixes (both in Hammerspoon and in Spoons) - this is just a suggested format for those, feel free to disagree.

Copy link

@github-actionsgithub-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This pull request does not contain a valid label. Please add one of the following labels:pr-fix, pr-change, pr-feature, pr-maintenance

@github-actions
Copy link

github-actionsbot commentedApr 5, 2021
edited
Loading

Release Notes Preview

Other:

@codecov
Copy link

codecovbot commentedApr 5, 2021
edited
Loading

Codecov Report

Merging#2805 (85ca71d) intomaster (005d208) willdecrease coverage by0.46%.
Report is 908 commits behind head on master.
The diff coverage isn/a.

❗ Current head85ca71d differs from pull request most recent heada312dc8. Consider uploading reports for the commita312dc8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@##           master    #2805      +/-   ##==========================================- Coverage   27.24%   26.78%   -0.46%==========================================  Files         179      179                Lines       36063    36063              ==========================================- Hits         9826     9661     -165- Misses      26237    26402     +165

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

except:
warn("Unable to parse parameters for %s\n%s\n"% (item["signature"],sys.exc_info()[1]))
exceptExceptionase:
warn("Unable to parse parameters for %s\n%s\n"% (item["signature"],repr(e)))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

E501 line too long (90 > 79 characters)

@github-actions

This comment has been minimized.

@cmsj
Copy link
Member

cmsj commentedApr 7, 2021

@Habbie could we have this again, without the/usr/bin/env change, since that's now been handled by#2798

@github-actions
Copy link

View Test Results

    1 files  ±0    27 suites  ±0   4m 54s ⏱️ -3s
330 tests ±0  330 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit85ca71d. ± Comparison against base commit005d208.

@@ -1,4 +1,4 @@
#!/usr/bin/python3
#!/usr/bin/envpython3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This part is no longer needed, it was already handled by another PR.

@cmsjcmsj added the pr-maintenancePull Request for uninteresting maintenance work labelApr 19, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@cmsjcmsjcmsj requested changes

@github-actionsgithub-actions[bot]github-actions[bot] approved these changes

+1 more reviewer

@stickler-cistickler-cistickler-ci left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pr-maintenancePull Request for uninteresting maintenance work

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Habbie@cmsj@stickler-ci

[8]ページ先頭

©2009-2025 Movatter.jp