- Notifications
You must be signed in to change notification settings - Fork4.1k
Fix Entity Source IDs Tracking ProblemDuring Relationship Processing#2279
Fix Entity Source IDs Tracking ProblemDuring Relationship Processing#2279danielaskdd merged 6 commits intoHKUDS:mainfrom
Conversation
• Remove verbose entity rebuild logging• Sort IDs before vector DB updates• Keep graph storage with original order
- Handle existing node updates properly in edge merging stage- Fix source_ids merging logic- Reorder entity deletion and optimize node operations- Delete relationships before entities- Add edge existence debugging logs
danielaskdd commentedOct 28, 2025
@codex review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Uh oh!
There was an error while loading.Please reload this page.
- Add /static to VITE_API_ENDPOINTS- Update proxy rewrite rules- Include static file serving- Sync sample env file
ec79727 intoHKUDS:mainUh oh!
There was an error while loading.Please reload this page.
Fix Entity Source IDs Tracking ProblemDuring Relationship Processing
Problem
Missing source_id updates for entities created via relationships - In
_merge_edges_then_upsert(), when processing relationships, existing entities weren't getting theirsource_idlists updated with chunks when source or target node missing in new relationships of current document.Impact:
Solution
When an existing entity is encountered during relationship processing, the code now:
entity_chunks_storageentity_chunks_storage(only when data actually changes)apply_source_ids_limit()Testing Recommendations